Hi Jukka,
On 03/19/2013 03:43 PM, Jukka Rissanen wrote:
Hi Daniel,
just a minor notice about the error prints in the code.
+ connman_warn("Failed to install iptables rules: %s",
strerror(-err));
+
What about adding also the value of -err to the print?
The error code is printed in many places in other parts of connman code
and sometimes it is useful when figuring out what the actual error is
(no need to map the string back to number).
Sure, I do not mind to have the error code as well or just the error
code. At one point I was thinking maybe we should use '%m' instead of
strerror. But that is properly out of scope right now.
cheers,
daniel
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
