From: Daniel Wagner <[email protected]>

Because need_split was reinitialized to false for each iteration
the do_split_routing was never considered.

Reported by coverity.
---
 src/service.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/service.c b/src/service.c
index 8753247..644aa57 100644
--- a/src/service.c
+++ b/src/service.c
@@ -3623,12 +3623,12 @@ void __connman_service_auto_connect(void)
 
 static gboolean run_vpn_auto_connect(gpointer data) {
        GList *list;
+       bool need_split = false;
 
        vpn_autoconnect_timeout = 0;
 
        for (list = service_list; list; list = list->next) {
                struct connman_service *service = list->data;
-               bool need_split = false;
                int res;
 
                if (service->type != CONNMAN_SERVICE_TYPE_VPN)
-- 
1.8.4.474.g128a96c

_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman

Reply via email to