>> --- a/src/dnsproxy.c
>> +++ b/src/dnsproxy.c
>> @@ -2068,7 +2068,8 @@ static int forward_dns_reply(unsigned char *reply, int 
>> reply_len, int protocol,
>>       }
>>
>>  out:
>> -     if (hdr->rcode > 0 && req->numresp < req->numserv)
>> +     if ((hdr->rcode > 0 || (hdr->rcode == 0 && hdr->ancount == 0 &&
>> +             req->append_domain)) && req->numresp < req->numserv)
>>               return -EINVAL;
>>
>>       request_list = g_slist_remove(request_list, req);
>Looks good, couple of comments

I did the modifications requested, both the commit message and the patch itself 
should look more clear now. Revised patch has subject "[PATCH] dnsproxy: Prefer 
responses with ancount>0 if append_domain is true".

Br,
Pasi
_______________________________________________
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman

Reply via email to