Hi,
On Thu, 2014-09-11 at 16:14 +0200, Peter Meerwald wrote:
> - if (address && c_address && g_strcmp0(address, c_address) != 0)
> + if (g_strcmp0(address, c_address) != 0)
> ip_change = true;
> - else if (gateway && c_gateway && g_strcmp0(gateway, c_gateway) != 0)
> + else if (g_strcmp0(gateway, c_gateway) != 0)
Nitpick, but plain 'g_strcmp0(...)' is preferred here.
> ip_change = true;
> else if (prefixlen != c_prefixlen)
> ip_change = true;
> - else if (!c_address || !c_gateway)
> - ip_change = true;
Should this also be 'g_strcmp0(...)'? So that if the gateway changes,
becomes set or unset, an update is made.
> else
> ip_change = false;
Cheers,
Patrik
_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman
