Hello Patrik,

> > > > -       else if (!c_address || !c_gateway)
> > > > -               ip_change = true;
> > > 
> > > Should this also be 'g_strcmp0(...)'? So that if the gateway
> > changes,
> > > becomes set or unset, an update is made.
> > 
> > I don't understand the comment;
> 
> Sorry, misread. It was c_address and c_gateway, not a comparison between
> something new and old.

even though if no gateway is given by DHCP, connman currently adds a route
destination 0.0.0.0 gw 0.0.0.0 -- is this intended?

maybe this should be addressed by a separate patch... (it doesn't seem to 
harm)

p.

-- 

Peter Meerwald
+43-664-2444418 (mobile)
_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman

Reply via email to