On Thu, 2014-12-18 at 14:10 +0000, Pasi Sjöholm wrote:
> >I think most of the problem solved by this patch set revolves around the
> >problem that incomplete information is suddenly received from oFono.
> >
> >What is the minimum acceptable configuration from oFono? At least
> >missing 'Address' and perhaps also 'Interface' property should ring
> >alarm bells, is the whole setup faulty in this case?
> >
> >E.g. should most of the patches be fixed by a strategic check of
> >
> >if (index < 0 || !address || !...)
> > goto out;
>
> If ipv4_method is dhcp there will be no address, and neither there
> will an address with ipv6 when dual-mode (slaac & dhcpv6) is used.
> So we just can jump into conlusions..
Let's start from the basics. Please explain the following:
- When there is an IPv4 only bearer, which are the possible IPv4
configuration methods?
- When there is an IPv6 only bearer, which are the possible IPv6
configuration methodos?
- When there is a dual IPv4/IPv6 bearer, which are the possible IPv4
and IPv6 configuration methods?
This is important to understand, as I cannot make too much sense of the
other patches otherwise.
There can not be any "old" nameservers left hanging around, as the code
goes like this:
char *nameservers = NULL;
...
while (...)
...
g_free(context->ipv4_nameservers);
context->ipv4_nameservers = nameservers;
So if oFono provided no nameservers, they are unset after exiting this
function as far as I can see.
If oFono provided nameservers without giving an IP address, the
nameservers are currently remembered. Once DHCP is run, any DHCP
provided nameservers replace the old ones. If there are no nameservers
available via DHCP, the best thing one can do is to keep the ones
provided by oFono earlier with this message. If oFono is sending
outdated information it is not supposed to send when no IP address is
present (in the DHCP case, I assume), please fix oFono.
Cheers,
Patrik
_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman
