Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [RFC v2 6/8] ofono: implementation of simultaneous APNS
(Patrik Flykt)
2. Re: [RFC v2 0/8] Implementation of simultaneous internet
contexts activation (Patrik Flykt)
3. Re: Multiple interfaces being offered the same ip address
(Patrik Flykt)
4. Re: DHCP renewal failure (Patrik Flykt)
5. [PATCH] client: Do not add duplicate lines to history
(Jaakko Hannikainen)
6. Re: [PATCH] client: Do not add duplicate lines to history
(Patrik Flykt)
7. Re: [RFC v2 0/8] Implementation of simultaneous internet
contexts activation (Myl?ne JOSSERAND)
8. Re: [RFC v2 6/8] ofono: implementation of simultaneous APNS
(Myl?ne JOSSERAND)
----------------------------------------------------------------------
Message: 1
Date: Thu, 10 Dec 2015 10:32:10 +0200
From: Patrik Flykt <[email protected]>
To: Mylene JOSSERAND <[email protected]>
Cc: [email protected]
Subject: Re: [RFC v2 6/8] ofono: implementation of simultaneous APNS
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Fri, 2015-11-27 at 19:37 +0100, Mylene JOSSERAND wrote:
> This patch implements the use of simultaneous APNS (and so internet contexts).
> It removes the restriction about one Internet context per modem and
> inverts the logic of the GetContexts function reply (which exited on first
> context).
> ---
> plugins/ofono.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/plugins/ofono.c b/plugins/ofono.c
> index e4a6c55..f157436 100644
> --- a/plugins/ofono.c
> +++ b/plugins/ofono.c
> @@ -1178,14 +1178,6 @@ static int add_cm_context(struct modem_data *modem,
> const char *context_path,
>
> DBG("%s context path %s", modem->path, context_path);
>
> - if (modem->context) {
> - /*
> - * We have already assigned a context to this modem
> - * and we do only support one Internet context.
> - */
> - return -EALREADY;
> - }
> -
> context = network_context_alloc(context_path);
> if (!context)
> return -ENOMEM;
> @@ -1441,7 +1433,7 @@ static void cm_get_contexts_reply(DBusPendingCall
> *call, void *user_data)
> dbus_message_iter_next(&entry);
> dbus_message_iter_recurse(&entry, &value);
>
> - if (add_cm_context(modem, context_path, &value) == 0)
> + if (add_cm_context(modem, context_path, &value) != 0)
This one would be according to codign style if written as
if(add_cm_context(...))
> break;
>
> dbus_message_iter_next(&dict);
Patrik
------------------------------
Message: 2
Date: Thu, 10 Dec 2015 10:39:35 +0200
From: Patrik Flykt <[email protected]>
To: Mylene JOSSERAND <[email protected]>
Cc: [email protected]
Subject: Re: [RFC v2 0/8] Implementation of simultaneous internet
contexts activation
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Fri, 2015-11-27 at 19:37 +0100, Mylene JOSSERAND wrote:
> This patchset updates and implements in ofono's plugin a simultaneous
> internet contexts activation per modem. Thanks to these patches, we
> can create two (or more) contexts for one modem and activates them
> simultaneous (if the modem handles it). It has been tested with a
> cinterion pxs8 for two contexts : one for QMI and another for PPP
> interface.
>
> This is the second version. I tried to split the best I can according
> to previous comments but I think it can be improved (that is why I put
> it in RFC again).
>
> Thank you in advance for patch reviews.
Thanks for the work, very much appreciated! Some of the patches got
comments from either me or gcc, but otherwise it looks very good. The
patch split up is nice, this way it is possible to review it in a sane
manner.
Sorry it took me almost two weeks to comment on this. I'll reserve some
time for applying this tomorrow if you by chance happen to have time to
send the patch set once more before that. I'd like to have a ConnMan
release soonishly as there are quite a lot of changes already that would
need to get into people's systems.
Thanks,
Patrik
> Mylene JOSSERAND (8):
> ofono: create a list of contexts
> ofono: move some properties to context struct
> ofono: move "network" property to context struct
> ofono: add network_context to property info
> ofono: remove the context struct in modem one
> ofono: implementation of simultaneous APNS
> ofono: add array parsing when contexts are added
> ofono: set "powered" property according to value
>
> plugins/ofono.c | 489
> +++++++++++++++++++++++++++++++++++---------------------
> 1 file changed, 310 insertions(+), 179 deletions(-)
>
------------------------------
Message: 3
Date: Thu, 10 Dec 2015 11:05:53 +0200
From: Patrik Flykt <[email protected]>
To: Usman S <[email protected]>
Cc: [email protected]
Subject: Re: Multiple interfaces being offered the same ip address
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Wed, 2015-12-09 at 09:46 +0000, Usman S wrote:
> Hi,
>
> Could you please let me know how does connman handles when a connected
> device offers an ip via dhcp when one of its existing
> interface/technology is already configured with the same ip i.e., in
> case of managing multiple technologies. Would connman decline the
> offer and ask for a new ip. Could you please give me some details on
> this.
Currently ConnMan does not look at the IP addresses handed out. It
should receive different ones, as the client id in the DHCP request is
different?
Cheers,
Patrik
------------------------------
Message: 4
Date: Thu, 10 Dec 2015 11:12:13 +0200
From: Patrik Flykt <[email protected]>
To: Naveen Singh <[email protected]>
Cc: [email protected]
Subject: Re: DHCP renewal failure
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
Hi,
On Fri, 2015-12-04 at 07:28 -0800, Naveen Singh wrote:
> Hi All
> In case of DHCP server not being available and eventually device
> failing to renew its IP address, I am observing following:
>
> 1. Connman service state is left to online.
>
> 2. Although the connman_ipconfig structure entries for ipv4 address is
> cleared out, connman never generated service property changed event.
> This probably is because DHCP renewal process never feeds back to
> service state machine from where we generate these events. At this
> point if we run connmanctl, for ipv4 configuration it will still show
> the old IP address.
This looks like a bug needing fixing. The state should be disconnected
or configuration and eventually ready if IPv4LL is an option for this
service. Provided that IPv6 is not already online for this service.
> 3. I am not sure how IPV4LL would be handled.
>
> Not sure if we can do anything for 1 or not as connman service state
> is an OR of ipv4 service state and ipv6 service state. But for sure 2
> looks like an issue. Currently there is no API to indicate clearing of
> IP address. I am working on a patch to have an API which would
> indicate generating of a Service property changed API when IP address
> is set to NULL. But before that I wanted to get the feedback on the
> current behavior and find out if this is an intended behavior or a
> bug?
I don't think there is a need for an new API here. When service state is
updated, a new State property is sent. It seems it all depends on the
non-information that DHCP lost its address, which when fixed will
resolve all three points above.
Cheers,
Patrik
------------------------------
Message: 5
Date: Thu, 10 Dec 2015 12:02:35 +0200
From: Jaakko Hannikainen <[email protected]>
To: [email protected]
Subject: [PATCH] client: Do not add duplicate lines to history
Message-ID:
<[email protected]>
When issuing the same command multiple times in a row,
all instances are saved to the history. A better way to
handle is to not add anything to history if the previous
command was equal to the current one.
---
client/input.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/client/input.c b/client/input.c
index e59df8a..d462c4a 100644
--- a/client/input.c
+++ b/client/input.c
@@ -103,8 +103,9 @@ static void rl_handler(char *input)
}
if (len > 0) {
-
- add_history(input);
+ HIST_ENTRY *previous = history_get(where_history());
+ if(!previous || strcmp(previous->line, input) != 0)
+ add_history(input);
err = __connmanctl_commands(connection, trim_args, len);
--
2.6.3
------------------------------
Message: 6
Date: Thu, 10 Dec 2015 15:18:15 +0200
From: Patrik Flykt <[email protected]>
To: Jaakko Hannikainen <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] client: Do not add duplicate lines to history
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Thu, 2015-12-10 at 12:02 +0200, Jaakko Hannikainen wrote:
> When issuing the same command multiple times in a row,
> all instances are saved to the history. A better way to
> handle is to not add anything to history if the previous
> command was equal to the current one.
Applied, thanks.
Patrik
------------------------------
Message: 7
Date: Thu, 10 Dec 2015 14:27:53 +0100
From: Myl?ne JOSSERAND <[email protected]>
To: Patrik Flykt <[email protected]>
Cc: [email protected]
Subject: Re: [RFC v2 0/8] Implementation of simultaneous internet
contexts activation
Message-ID:
<camvtsxouwwzb_kn3zwuyoijxzzyhwn3uavbstt+nwanawzr...@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Hi Patrik,
2015-12-10 9:39 GMT+01:00 Patrik Flykt <[email protected]>:
> On Fri, 2015-11-27 at 19:37 +0100, Mylene JOSSERAND wrote:
> > This patchset updates and implements in ofono's plugin a simultaneous
> > internet contexts activation per modem. Thanks to these patches, we
> > can create two (or more) contexts for one modem and activates them
> > simultaneous (if the modem handles it). It has been tested with a
> > cinterion pxs8 for two contexts : one for QMI and another for PPP
> > interface.
> >
> > This is the second version. I tried to split the best I can according
> > to previous comments but I think it can be improved (that is why I put
> > it in RFC again).
> >
> > Thank you in advance for patch reviews.
>
> Thanks for the work, very much appreciated! Some of the patches got
> comments from either me or gcc, but otherwise it looks very good. The
> patch split up is nice, this way it is possible to review it in a sane
> manner.
>
Thank you very much for your patch review !
In fact, this is my first "patchset" contribution so I did not know that
each patch of the series should be compiled.
I compiled it only at the end of the patch series, that's why there are
some gcc warnings/errors on "middle" patches.
Sorry for that and thank you !
>
> Sorry it took me almost two weeks to comment on this.
Do not worry, I understand. I sent this second series one month later so I
am not an example ;-)
> I'll reserve some
> time for applying this tomorrow if you by chance happen to have time to
> send the patch set once more before that.
Okay, I will try to send a corrected patchset today.
> I'd like to have a ConnMan
> release soonishly as there are quite a lot of changes already that would
> need to get into people's systems.
>
I understand.
Thank you,
Best regards,
Myl?ne JOSSERAND
>
> Thanks,
>
> Patrik
>
> > Mylene JOSSERAND (8):
> > ofono: create a list of contexts
> > ofono: move some properties to context struct
> > ofono: move "network" property to context struct
> > ofono: add network_context to property info
> > ofono: remove the context struct in modem one
> > ofono: implementation of simultaneous APNS
> > ofono: add array parsing when contexts are added
> > ofono: set "powered" property according to value
> >
> > plugins/ofono.c | 489
> +++++++++++++++++++++++++++++++++++---------------------
> > 1 file changed, 310 insertions(+), 179 deletions(-)
> >
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.01.org/pipermail/connman/attachments/20151210/f72edda4/attachment-0001.html>
------------------------------
Message: 8
Date: Thu, 10 Dec 2015 14:35:45 +0100
From: Myl?ne JOSSERAND <[email protected]>
To: Patrik Flykt <[email protected]>
Cc: [email protected]
Subject: Re: [RFC v2 6/8] ofono: implementation of simultaneous APNS
Message-ID:
<CAMvtsXrO0sYb5m=tJq3YwoyeGt_ZSr=vd_nv+e+weuvcyh0...@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Hi,
2015-12-10 9:32 GMT+01:00 Patrik Flykt <[email protected]>:
> On Fri, 2015-11-27 at 19:37 +0100, Mylene JOSSERAND wrote:
> > This patch implements the use of simultaneous APNS (and so internet
> contexts).
> > It removes the restriction about one Internet context per modem and
> > inverts the logic of the GetContexts function reply (which exited on
> first context).
> > ---
> > plugins/ofono.c | 10 +---------
> > 1 file changed, 1 insertion(+), 9 deletions(-)
> >
> > diff --git a/plugins/ofono.c b/plugins/ofono.c
> > index e4a6c55..f157436 100644
> > --- a/plugins/ofono.c
> > +++ b/plugins/ofono.c
> > @@ -1178,14 +1178,6 @@ static int add_cm_context(struct modem_data
> *modem, const char *context_path,
> >
> > DBG("%s context path %s", modem->path, context_path);
> >
> > - if (modem->context) {
> > - /*
> > - * We have already assigned a context to this modem
> > - * and we do only support one Internet context.
> > - */
> > - return -EALREADY;
> > - }
> > -
> > context = network_context_alloc(context_path);
> > if (!context)
> > return -ENOMEM;
> > @@ -1441,7 +1433,7 @@ static void cm_get_contexts_reply(DBusPendingCall
> *call, void *user_data)
> > dbus_message_iter_next(&entry);
> > dbus_message_iter_recurse(&entry, &value);
> >
> > - if (add_cm_context(modem, context_path, &value) == 0)
> > + if (add_cm_context(modem, context_path, &value) != 0)
>
> This one would be according to codign style if written as
> if(add_cm_context(...))
>
ah ? The parenthesis should be stuck to the "if" ?
Best regards,
Myl?ne JOSSERAND
>
> > break;
> >
> > dbus_message_iter_next(&dict);
>
>
> Patrik
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.01.org/pipermail/connman/attachments/20151210/250d090f/attachment.html>
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 2, Issue 11
**************************************
