Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [RFC v2 6/8] ofono: implementation of simultaneous APNS
(Sven Schwedas)
2. Re: [RFC v2 6/8] ofono: implementation of simultaneous APNS
(Myl?ne JOSSERAND)
----------------------------------------------------------------------
Message: 1
Date: Thu, 10 Dec 2015 14:48:53 +0100
From: Sven Schwedas <[email protected]>
To: [email protected]
Subject: Re: [RFC v2 6/8] ofono: implementation of simultaneous APNS
Message-ID: <[email protected]>
Content-Type: text/plain; charset="windows-1252"
On 2015-12-10 14:35, Myl?ne JOSSERAND wrote:
> > - if (add_cm_context(modem, context_path, &value) == 0)
> > + if (add_cm_context(modem, context_path, &value) != 0)
>
> This one would be according to codign style if written as
> if(add_cm_context(...))
>
>
>
> ah ? The parenthesis should be stuck to the "if" ?
More importantly, the != 0 is redundant here.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 648 bytes
Desc: OpenPGP digital signature
URL:
<http://lists.01.org/pipermail/connman/attachments/20151210/24f27557/attachment-0001.asc>
------------------------------
Message: 2
Date: Thu, 10 Dec 2015 15:17:33 +0100
From: Myl?ne JOSSERAND <[email protected]>
To: Sven Schwedas <[email protected]>
Cc: [email protected]
Subject: Re: [RFC v2 6/8] ofono: implementation of simultaneous APNS
Message-ID:
<CAMvtsXo=Yy3jR6Ep9DRMJBa51bCOR==xcvsgc-xroe51y4z...@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Hi,
2015-12-10 14:48 GMT+01:00 Sven Schwedas <[email protected]>:
>
>
> On 2015-12-10 14:35, Myl?ne JOSSERAND wrote:
> > > - if (add_cm_context(modem, context_path, &value) == 0)
> > > + if (add_cm_context(modem, context_path, &value) != 0)
> >
> > This one would be according to codign style if written as
> > if(add_cm_context(...))
> >
> >
> >
> > ah ? The parenthesis should be stuck to the "if" ?
>
> More importantly, the != 0 is redundant here.
>
>
ahh, yes ! sorry, I feel stupid, I did not notice it. I was focused on
spaces, I do not why.
Thanks !
Mylene JOSSERAND
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.01.org/pipermail/connman/attachments/20151210/7357f6e1/attachment-0001.html>
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 2, Issue 12
**************************************
