Send connman mailing list submissions to
        [email protected]

To subscribe or unsubscribe via the World Wide Web, visit
        https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
        [email protected]

You can reach the person managing the list at
        [email protected]

When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."


Today's Topics:

   1. FW: [PATCH] dhcp: Follow the RFC regarding ordrer of "subnet"
      and "router" option (Kristian Klausen)


----------------------------------------------------------------------

Message: 1
Date: Fri, 30 Sep 2016 13:24:34 +0200
From: Kristian Klausen <[email protected]>
To: "[email protected]" <[email protected]>
Subject: FW: [PATCH] dhcp: Follow the RFC regarding ordrer of "subnet"
        and "router" option
Message-ID: <[email protected]>
Content-Type: text/plain; charset="iso-8859-1"

Resending because it seems like I need to be subscribed, before I can post.
and it impossible to get in contact with any Connman dev (which could check the 
mail, and allow it to be posted).. At least on #connman on freenode.

----------------------------------------
> From: [email protected]
> To: [email protected]
> Subject: [PATCH] dhcp: Follow the RFC regarding ordrer of "subnet" and 
> "router" option
> Date: Wed, 28 Sep 2016 22:17:30 +0200
>
> The 2132 RFC clearly state, that the "subnet" option should be before
> the "router" option.
>
> "If both the subnet mask and the router option are specified in a DHCP
> reply, the subnet mask option MUST be first."
> - https://tools.ietf.org/html/rfc2132#section-3.3
>
> Some dhcp servers (D-Link DSR-1000) doesn't responds correctly, if that
> isn't the case.
> For example the D-Link DSR-1000 which respond back with a DHCPACK
> containing two "subnet" option but no "router" option.
> ---
>  src/dhcp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/dhcp.c b/src/dhcp.c
> index 57e7ac9..4d23581 100644
> --- a/src/dhcp.c
> +++ b/src/dhcp.c
> @@ -576,8 +576,8 @@ static int dhcp_initialize(struct connman_dhcp *dhcp)
>          g_dhcp_client_set_request(dhcp_client, G_DHCP_MTU);
>      }
>
> -    g_dhcp_client_set_request(dhcp_client, G_DHCP_SUBNET);
>      g_dhcp_client_set_request(dhcp_client, G_DHCP_ROUTER);
> +    g_dhcp_client_set_request(dhcp_client, G_DHCP_SUBNET);
>
>      g_dhcp_client_register_event(dhcp_client,
>              G_DHCP_CLIENT_EVENT_LEASE_AVAILABLE,
> --
> 2.10.0
>
>
                                          

------------------------------

Subject: Digest Footer

_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman


------------------------------

End of connman Digest, Vol 11, Issue 29
***************************************

Reply via email to