Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH] timezone: Add support for setting timezone using
timedated (Philip Withnall)
2. Re: [PATCH] gweb: Do not lookup for a NULL key in a hash
table (M?ns Rullg?rd)
----------------------------------------------------------------------
Message: 1
Date: Sat, 01 Oct 2016 12:03:52 +0200
From: Philip Withnall <[email protected]>
To: [email protected]
Subject: Re: [PATCH] timezone: Add support for setting timezone using
timedated
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"
On Wed, 2016-09-07 at 11:07 +0100, Philip Withnall wrote:
> Hi,
>
> On Sun, 2016-08-28 at 12:24 +0300, Slava Monich wrote:
> >
> > On 27/08/16 17:15, Marcel Holtmann wrote:
> > >
> > > >
> > > > If we are running under systemd, the ProtectSystem key in our
> > > > .service
> > > > file prevents us from writing to /etc/localtime. Instead, set the
> > > > timezone by using org.freedesktop.timedate1 over D-Bus, if it is
> > > > available. If it is not available, fall back to /etc/localtime.
> > > >
> > > > Signed-off-by: Philip Withnall <[email protected]>
> > > > ---
> > > > ? src/timezone.c | 213
> > > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> > > > ? 1 file changed, 210 insertions(+), 3 deletions(-)
> > > how hard would it to build a connman_timezone_driver_register
> > > infrastructure? Hard coding systemd D-Bus APIs and a fallback seems
> > > like the wrong approach. I think we should have a plugin to overwrite
> > > default behavior. Similar to what we do with proxies and other
> > > features.
>
> It?s more effort than I have time to put in at the moment, sorry.
> Hardcoding D-Bus APIs is (I believe) an acceptable approach, since the D-
> Bus API itself provides the indirection layer ? the API can be
> implemented
> by any system process. The ?fallback? (/etc/localtime) should work in 90%
> of cases at the moment (as it always has done).
Would it be possible to merge this? As I said, it?s an improvement in the
systemd case, and no change in the non-systemd case (certainly not a
regression). If someone wants to come along later and add a plugin API for
supporting systems other than systemd, that would be fine; but I don?t
currently have time for it. It would be nice if this patch didn?t bitrot in
the meantime.
Thanks,
Philip
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL:
<http://lists.01.org/pipermail/connman/attachments/20161001/a8378398/attachment-0001.asc>
------------------------------
Message: 2
Date: Sat, 01 Oct 2016 15:50:58 +0100
From: M?ns Rullg?rd <[email protected]>
To: Tomasz Bursztyka <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] gweb: Do not lookup for a NULL key in a hash
table
Message-ID: <[email protected]>
Content-Type: text/plain; charset=iso-8859-1
Tomasz Bursztyka <[email protected]> writes:
> At this position, no key might have been provided yet.
>
> Reported by Marcel Mulder <[email protected]>
> ---
>
> Hi Marcel,
>
> Does that helps?
>
> Btw the logs you provided are missing the gweb parts.
> Could you run connman like: CONNMAN_WEB_DEBUG=1 connmnand <your options>
Did this ever get fixed properly?
> gweb/gweb.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/gweb/gweb.c b/gweb/gweb.c
> index f6828cf..7771190 100644
> --- a/gweb/gweb.c
> +++ b/gweb/gweb.c
> @@ -806,6 +806,9 @@ static void handle_multi_line(struct web_session *session)
> g_string_insert_c(session->current_header, 0, ' ');
> }
>
> + if (!session->result.last_key)
> + return;
> +
> value = g_hash_table_lookup(session->result.headers,
> session->result.last_key);
> if (value) {
> --
> 1.8.3.2
--
M?ns Rullg?rd
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 12, Issue 1
**************************************
