Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. [PATCH] firewall-nftables: fix build with libnftnl-1.0.7
(Maxin B. John)
2. Value of IPv4.Method when IPv4LL (Jose Blanquicet)
----------------------------------------------------------------------
Message: 1
Date: Mon, 8 May 2017 11:29:13 +0300
From: "Maxin B. John" <[email protected]>
To: [email protected]
Subject: [PATCH] firewall-nftables: fix build with libnftnl-1.0.7
Message-ID: <[email protected]>
We need these updates to accommodate the changes caused by the following
commit in libnftnl-1.0.7
commit 907a9f8e5a93f5bcd449643eb3916a656d634758
Author: Pablo Neira Ayuso <[email protected]>
Date: Tue Dec 20 13:47:11 2016 +0100
src: get rid of aliases and compat
This machinery was introduced to avoid sudden compilation breakage of
old nftables releases. With the upcoming release of 0.7 (and 0.6 which
is now 6 months old) this is not required anymore.
Moreover, users gain nothing from older releases since they are
half-boiled and buggy.
So let's get rid of aliases now. Bump LIBVERSION and update map file.
Signed-off-by: Maxin B. John <[email protected]>
---
src/firewall-nftables.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/firewall-nftables.c b/src/firewall-nftables.c
index 583d1c4..83b137b 100644
--- a/src/firewall-nftables.c
+++ b/src/firewall-nftables.c
@@ -387,9 +387,9 @@ static int add_cmp(struct nftnl_rule *rule, uint32_t sreg,
uint32_t op,
if (!expr)
return -ENOMEM;
- nftnl_expr_set_u32(expr, NFT_EXPR_CMP_SREG, sreg);
- nftnl_expr_set_u32(expr, NFT_EXPR_CMP_OP, op);
- nftnl_expr_set(expr, NFT_EXPR_CMP_DATA, data, data_len);
+ nftnl_expr_set_u32(expr, NFTNL_EXPR_CMP_SREG, sreg);
+ nftnl_expr_set_u32(expr, NFTNL_EXPR_CMP_OP, op);
+ nftnl_expr_set(expr, NFTNL_EXPR_CMP_DATA, data, data_len);
nftnl_rule_add_expr(rule, expr);
@@ -575,8 +575,8 @@ static int build_rule_nat(const char *address, unsigned
char prefixlen,
expr = nftnl_expr_alloc("meta");
if (!expr)
goto err;
- nftnl_expr_set_u32(expr, NFT_EXPR_META_KEY, NFT_META_OIFNAME);
- nftnl_expr_set_u32(expr, NFT_EXPR_META_DREG, NFT_REG_1);
+ nftnl_expr_set_u32(expr, NFTNL_EXPR_META_KEY, NFT_META_OIFNAME);
+ nftnl_expr_set_u32(expr, NFTNL_EXPR_META_DREG, NFT_REG_1);
nftnl_rule_add_expr(rule, expr);
err = add_cmp(rule, NFT_REG_1, NFT_CMP_EQ, interface,
strlen(interface) + 1);
@@ -677,8 +677,8 @@ static int build_rule_snat(int index, const char *address,
expr = nftnl_expr_alloc("meta");
if (!expr)
goto err;
- nftnl_expr_set_u32(expr, NFT_EXPR_META_KEY, NFT_META_OIF);
- nftnl_expr_set_u32(expr, NFT_EXPR_META_DREG, NFT_REG_1);
+ nftnl_expr_set_u32(expr, NFTNL_EXPR_META_KEY, NFT_META_OIF);
+ nftnl_expr_set_u32(expr, NFTNL_EXPR_META_DREG, NFT_REG_1);
nftnl_rule_add_expr(rule, expr);
err = add_cmp(rule, NFT_REG_1, NFT_CMP_EQ, &index, sizeof(index));
if (err < 0)
--
2.4.0
------------------------------
Message: 2
Date: Mon, 8 May 2017 14:40:45 +0000
From: Jose Blanquicet <[email protected]>
To: [email protected]
Subject: Value of IPv4.Method when IPv4LL
Message-ID:
<cafc8ij+stuip5minwngax-4mfzcxugjjuyv8arak0otdhcf...@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Hi,
After a successful connection to a service, ConnMan starts DHCP
procedure to get an IPv4. However, if such procedure fails then
ConnMan will assign a Link-local address to that given interface. At
the end of this process, ConnMan will notify the assigned IPv4 address
with "dhcp" as method. We consider it should be "auto" in order to let
know that the DHCP process failed and that address is a Link-local
address. What do people think?
Regards,
Jose Blanquicet
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 19, Issue 4
**************************************
