Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Connman not configuring Ethernet port (David Aldrich)
2. [PATCH] inet: Return error if pnp_file doesn't exists
(Saurav Babu)
3. Connman not configuring Ethernet port (David Aldrich)
----------------------------------------------------------------------
Message: 1
Date: Wed, 10 May 2017 12:28:53 +0000
From: David Aldrich <[email protected]>
To: "[email protected]" <[email protected]>
Subject: Connman not configuring Ethernet port
Message-ID: <[email protected]>
Content-Type: text/plain; charset="iso-2022-jp"
Hi
I have installed the connman client onto a clean Wind River Linux installation:
rpm -ivh --nodeps connman-client-1.30-r0.0.haswell_64.rpm
I can run connmanctl and configure a service. I see it?s settings in:
/var/lib/connman/ethernet_00110a6981f8_cable
The connman service is running:
# systemctl status connman.service
? connman.service - Connection service
Loaded: loaded (/lib/systemd/system/connman.service; enabled; vendor preset:
enabled)
Active: active (running) since Wed 2017-05-10 11:28:32 UTC; 58min ago
But when I reboot the system the Ethernet port in question is not assigned the
IP address that I specified to connman.
What should I check please?
Best regards
David
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.01.org/pipermail/connman/attachments/20170510/cca92e7d/attachment-0001.html>
------------------------------
Message: 2
Date: Wed, 10 May 2017 18:07:03 +0530
From: Saurav Babu <[email protected]>
To: [email protected]
Cc: [email protected], Saurav Babu <[email protected]>
Subject: [PATCH] inet: Return error if pnp_file doesn't exists
Message-ID:
<[email protected]>
Content-Type: text/plain; charset="utf-8"
If pnp_file doesn't exists then its contents were not read and pnp
variable remained NULL. Later when pnp variable was passed to
g_strsplit() function then below GLib warning occured:
(connmand:32767): GLib-CRITICAL **: g_strsplit: assertion 'string != NULL'
failed
connmand[32767]: get_nfs_server_ip: Cannot split pnp at file "/proc/net/pnp"
This patch returns error if pnp_file doesn't exists
---
src/inet.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/src/inet.c b/src/inet.c
index b283db8..b887aa0 100644
--- a/src/inet.c
+++ b/src/inet.c
@@ -2997,10 +2997,14 @@ static int get_nfs_server_ip(const char *cmdline_file,
const char *pnp_file,
goto out;
}
- if (g_file_test(pnp_file, G_FILE_TEST_EXISTS) &&
- !g_file_get_contents(pnp_file, &pnp, NULL, &error)) {
- connman_error("%s: Cannot read %s %s\n", __func__,
- pnp_file, error->message);
+ if (g_file_test(pnp_file, G_FILE_TEST_EXISTS)) {
+ if (!g_file_get_contents(pnp_file, &pnp, NULL, &error)) {
+ connman_error("%s: Cannot read %s %s\n", __func__,
+ pnp_file, error->message);
+ goto out;
+ }
+ } else {
+ connman_error("%s: File %s doesn't exist\n", __func__,
pnp_file);
goto out;
}
--
1.9.1
------------------------------
Message: 3
Date: Wed, 10 May 2017 13:30:53 +0000
From: David Aldrich <[email protected]>
To: "[email protected]" <[email protected]>
Subject: Connman not configuring Ethernet port
Message-ID: <[email protected]>
Content-Type: text/plain; charset="us-ascii"
Actually, seems to be working ok now. Please ignore my question.
Best regards
David
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.01.org/pipermail/connman/attachments/20170510/7b259812/attachment-0001.html>
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 19, Issue 5
**************************************
