Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH] device: Empty networks table before freeing
device ident (Daniel Wagner)
2. Re: [PATCH] firewall-nftables: fix build with libnftnl-1.0.7
(Daniel Wagner)
3. Re: Value of IPv4.Method when IPv4LL (Daniel Wagner)
4. Re: [PATCH] inet: Return error if pnp_file doesn't exists
(Daniel Wagner)
5. Re: Connman not configuring Ethernet port (Daniel Wagner)
6. Re: Connman not configuring Ethernet port (Daniel Wagner)
----------------------------------------------------------------------
Message: 1
Date: Sat, 13 May 2017 09:03:51 +0200
From: Daniel Wagner <[email protected]>
To: Slava Monich <[email protected]>, [email protected]
Subject: Re: [PATCH] device: Empty networks table before freeing
device ident
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Slava,
On 05/04/2017 04:40 PM, Slava Monich wrote:
> Networks still need it when they are being deallocated:
>
> #0 connman_device_get_ident (src/device.c)
> #1 __connman_network_get_ident (src/network.c)
> #2 connman_service_lookup_from_network (src/service.c)
> #3 __connman_service_remove_from_network (src/service.c)
> #4 network_remove (src/network.c)
> #5 __connman_network_set_device (src/network.c)
> #6 free_network (src/device.c)
> #7 g_hash_table_remove_all_nodes (ghash.c)
> #9 g_hash_table_remove_all (ghash.c)
> #10 g_hash_table_destroy (ghash.c)
> #11 device_destruct (src/device.c)
>
> which results in use after free.
Patch applied.
Thank,
Daniel
------------------------------
Message: 2
Date: Sat, 13 May 2017 09:16:25 +0200
From: Daniel Wagner <[email protected]>
To: "Maxin B. John" <[email protected]>, [email protected]
Subject: Re: [PATCH] firewall-nftables: fix build with libnftnl-1.0.7
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Maxin,
On 05/08/2017 10:29 AM, Maxin B. John wrote:
> We need these updates to accommodate the changes caused by the following
> commit in libnftnl-1.0.7
>
> commit 907a9f8e5a93f5bcd449643eb3916a656d634758
> Author: Pablo Neira Ayuso <[email protected]>
> Date: Tue Dec 20 13:47:11 2016 +0100
>
> src: get rid of aliases and compat
>
> This machinery was introduced to avoid sudden compilation breakage of
> old nftables releases. With the upcoming release of 0.7 (and 0.6 which
> is now 6 months old) this is not required anymore.
>
> Moreover, users gain nothing from older releases since they are
> half-boiled and buggy.
>
> So let's get rid of aliases now. Bump LIBVERSION and update map file.
I dropped the SoB because we don't do it in ConnMan. Works nicely on my F25.
Patch applied.
Thanks,
Daniel
------------------------------
Message: 3
Date: Sat, 13 May 2017 09:21:30 +0200
From: Daniel Wagner <[email protected]>
To: Jose Blanquicet <[email protected]>, [email protected]
Subject: Re: Value of IPv4.Method when IPv4LL
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Jose,
On 05/08/2017 04:40 PM, Jose Blanquicet wrote:
> Hi,
>
> After a successful connection to a service, ConnMan starts DHCP
> procedure to get an IPv4. However, if such procedure fails then
> ConnMan will assign a Link-local address to that given interface. At
> the end of this process, ConnMan will notify the assigned IPv4 address
> with "dhcp" as method.
Yep, that is indeed misleading.
> We consider it should be "auto" in order to let
> know that the DHCP process failed and that address is a Link-local
> address. What do people think?
According the docs we report for IPv4 dhcp, manual and off. For IPv6 is
auto, manual, 6to4 and off. If I got that correct[1] then is IPv6's auto
the LL for IPv4. So yes, that sounds the right thing to do.
Thanks,
Daniel
[1] https://en.wikipedia.org/wiki/Link-local_address
------------------------------
Message: 4
Date: Sat, 13 May 2017 09:25:56 +0200
From: Daniel Wagner <[email protected]>
To: Saurav Babu <[email protected]>, [email protected]
Cc: [email protected]
Subject: Re: [PATCH] inet: Return error if pnp_file doesn't exists
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Saurav,
On 05/10/2017 02:37 PM, Saurav Babu wrote:
> If pnp_file doesn't exists then its contents were not read and pnp
> variable remained NULL. Later when pnp variable was passed to
> g_strsplit() function then below GLib warning occured:
> (connmand:32767): GLib-CRITICAL **: g_strsplit: assertion 'string != NULL'
> failed
> connmand[32767]: get_nfs_server_ip: Cannot split pnp at file "/proc/net/pnp"
>
> This patch returns error if pnp_file doesn't exists
Ah thanks for fixing this. It was annoying me as well :)
Patch applied.
Thanks,
Daniel
------------------------------
Message: 5
Date: Sat, 13 May 2017 09:29:42 +0200
From: Daniel Wagner <[email protected]>
To: David Aldrich <[email protected]>, "[email protected]"
<[email protected]>
Subject: Re: Connman not configuring Ethernet port
Message-ID: <[email protected]>
Content-Type: text/plain; charset=iso-2022-jp; format=flowed;
delsp=yes
Hi David,
On 05/10/2017 02:28 PM, David Aldrich wrote:
> Hi
>
> I have installed the connman client onto a clean Wind River Linux
> installation:
>
> rpm -ivh --nodeps connman-client-1.30-r0.0.haswell_64.rpm
>
> I can run connmanctl and configure a service. I see it?s settings in:
>
> /var/lib/connman/ethernet_00110a6981f8_cable
>
> The connman service is running:
>
> # systemctl status connman.service
>
> ? connman.service - Connection service
>
> Loaded: loaded (/lib/systemd/system/connman.service; enabled; vendor
> preset: enabled)
>
> Active: active (running) since Wed 2017-05-10 11:28:32 UTC; 58min ago
>
> But when I reboot the system the Ethernet port in question is not
> assigned the IP address that I specified to connman.
The files in /var/lib/connman/ethernet_00110a6981f8_cable are under
control of ConnMan. That means it will overwrite on shutdown anything
you have added before hand. Best is not to edit those file by hand
instead use the D-Bus API to configure. If that is no option make sure
ConnMan is not running while editing them.
Thanks,
Daniel
------------------------------
Message: 6
Date: Sat, 13 May 2017 09:30:16 +0200
From: Daniel Wagner <[email protected]>
To: David Aldrich <[email protected]>, "[email protected]"
<[email protected]>
Subject: Re: Connman not configuring Ethernet port
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252; format=flowed
Hi David,
On 05/10/2017 03:30 PM, David Aldrich wrote:
> Actually, seems to be working ok now. Please ignore my question.
Ah, nice :)
Thanks,
Daniel
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 19, Issue 8
**************************************
