Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH 1/2] wifi: Do not allow scan/autoscan on p2p
connected interface (Jose Blanquicet)
----------------------------------------------------------------------
Message: 1
Date: Mon, 19 Jun 2017 09:58:19 +0000
From: Jose Blanquicet <[email protected]>
To: Tomasz Bursztyka <[email protected]>
Cc: [email protected], Daniel Wagner <[email protected]>
Subject: Re: [PATCH 1/2] wifi: Do not allow scan/autoscan on p2p
connected interface
Message-ID:
<cafc8ijlpm0u7ma+ohbwdgsjyvha54igeyrawjyvwhy5qxzg...@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Hi Tomasz,
On Thu, Jun 8, 2017 at 7:40 PM, Daniel Wagner <[email protected]> wrote:
>> From: Jose Blanquicet <[email protected]>
>>
>> In eed27a6e1d1 was introduced the concept of p2p_device to identify the
>> dedicated P2P-Group interface created by wpa_supplicant when a P2P
>> connection is established. This concept is used to deny Scan and Autoscan
>> (Introduced in b584447dde1) on P2P connected interfaces.
>>
>> However, if wpa_supplicant is configured to not create such dedicated
>> P2P-Group interface and instead use directly the same one, then ConnMan
>> needs a way to continue denying Scan/Autoscan on that P2P connected
>> interface and that is the scope if this patch. With this modification,
>> the p2p_device flag is also used to temporally mark the current interface
>> connected with P2P.
>
>
> Could you comment on this series? I looks good to me but I haven't really
> worked with P2P.
Ping.
Any feedback on this topic?
Thanks,
Jose Blanquicet
>>
>> ---
>> plugins/wifi.c | 12 +++++++++++-
>> 1 file changed, 11 insertions(+), 1 deletion(-)
>>
>> diff --git a/plugins/wifi.c b/plugins/wifi.c
>> index a49031c..551cfea 100644
>> --- a/plugins/wifi.c
>> +++ b/plugins/wifi.c
>> @@ -402,8 +402,10 @@ static int peer_disconnect(struct connman_peer *peer)
>> &peer_params);
>> g_free(peer_params.path);
>> - if (ret == -EINPROGRESS)
>> + if (ret == -EINPROGRESS) {
>> peer_cancel_timeout(wifi);
>> + wifi->p2p_device = false;
>> + }
>> return ret;
>> }
>> @@ -2981,6 +2983,14 @@ static void peer_changed(GSupplicantPeer *peer,
>> GSupplicantPeerState state)
>> connman_peer_set_as_master(connman_peer,
>>
>> !g_supplicant_peer_is_client(peer));
>> connman_peer_set_sub_device(connman_peer, g_wifi->device);
>> +
>> + /*
>> + * If wpa_supplicant didn't create a dedicated p2p-group
>> + * interface then mark this interface as p2p_device to
>> avoid
>> + * scan and auto-scan are launched on it while P2P is
>> connected.
>> + */
>> + if (!g_list_find(p2p_iface_list, g_wifi))
>> + wifi->p2p_device = true;
>> }
>> connman_peer_set_state(connman_peer, p_state);
>>
>
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 20, Issue 10
***************************************
