Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. How to start PacRunner ? Systemd vs dbus auto start
(Julien Massot)
2. Re: [PATCH 0/5] Avoid to keep service in list if AP is not
found during scan (Jose Blanquicet)
3. [PATCH v2 0/6] Avoid to keep service in list if AP is not
found during scan (Jose Blanquicet)
4. [PATCH v2 1/6] iwd: Do not use connectable flag
([email protected])
5. [PATCH v2 2/6] Revert "device: Use network's connectable
flag" ([email protected])
6. [PATCH v2 3/6] Revert "plugins/wifi: Marking network's
Connectable flag as true." ([email protected])
----------------------------------------------------------------------
Message: 1
Date: Wed, 21 Jun 2017 15:52:06 +0200
From: Julien Massot <[email protected]>
To: [email protected]
Subject: How to start PacRunner ? Systemd vs dbus auto start
Message-ID:
<CADGp=qdbgpt-kxzys2vd136ms8ctgispaptcf_muxz_zvue...@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Hi all,
I'm currently integrating PacRunner,
but I don't see any recommended solution to start it.
PACRunner ship a dbus autostart file in:
/usr/share/dbus-1/system-services/pacrunner.service
BTW the path is not correct, I will send a patch to have
"org.pacrunner.service".
And PacRunner doesn't ship any systemd unit file, so my guess was that
ConnMan will start it through dbus if a proxy server is set manually, or if wpad
discover a pac/wpad file.
But ConnMan plugins doesn't call PacRunner if the daemon is not running,
and explicitely ask to not start the daemon.
static void destroy_proxy_configuration(void)
..
line 237: dbus_message_set_auto_start(msg, FALSE);
static void default_service_changed(struct connman_service *service)
..
line 267: if (!daemon_running)
return;
So from my point of view, shipping a systemd unit file is not the best solution,
since starting pacrunner on boot is a waste of time.
And ConnMan pacrunner plugin,
should try to autostart PacRunner if we connect to a network which
have a proxy configured or discovered.
Last solution should be that on a first call of libproxy pacrunner
starts but it look like a bad solution since most likely connman will
not send the proxy
configuration yet.
Regards,
Julien
--
*This email and any attachment thereto are confidential and intended solely
for the use of the individual or entity to whom they are addressed.If you
are not the intended recipient, please be advised that disclosing, copying,
distributing or taking any action in reliance on the contents of this email
is strictly prohibited. In such case, please immediately advise the sender,
and delete all copies and attachment from your system.This email shall not
be construed and is not tantamount to an offer, an acceptance of offer, or
an agreement by SoftBank Robotics Europe on any discussion or contractual
document whatsoever. No employee or agent is authorized to represent or
bind SoftBank Robotics Europe to third parties by email, or act on behalf
of SoftBank Robotics Europe by email, without express written confirmation
by SoftBank Robotics Europe? duly authorized representatives.*
------------------------------
*Ce message ?lectronique et ?ventuelles pi?ces jointes sont confidentiels,
et exclusivement destin?s ? la personne ou l'entit? ? qui ils sont
adress?s.Si vous n'?tes pas le destinataire vis?, vous ?tes pri? de ne pas
divulguer, copier, distribuer ou prendre toute d?cision sur la foi de ce
message ?lectronique. Merci d'en aviser imm?diatement l'exp?diteur et de
supprimer toutes les copies et ?ventuelles pi?ces jointes de votre
syst?me.Ce message ?lectronique n'?quivaut pas ? une offre, ? une
acceptation d?offre, ou ? un accord de SoftBank Robotics Europe sur toute
discussion ou document contractuel quel qu?il soit, et ne peut ?tre
interpr?t? comme tel. Aucun employ? ou agent de SoftBank Robotics Europe
n'est autoris? ? repr?senter ou ? engager la soci?t? par email, ou ? agir
au nom et pour le compte de la soci?t? par email, sans qu?une confirmation
?crite soit donn?e par le repr?sentant l?gal de SoftBank Robotics Europe ou
par toute autre personne ayant re?u d?l?gation de pouvoir appropri?e.*
------------------------------
Message: 2
Date: Wed, 21 Jun 2017 15:48:52 +0000
From: Jose Blanquicet <[email protected]>
To: Patrik Flykt <[email protected]>
Cc: Daniel Wagner <[email protected]>, [email protected]
Subject: Re: [PATCH 0/5] Avoid to keep service in list if AP is not
found during scan
Message-ID:
<cafc8ij+f_ypbemtbv_tzgjo7a8i1roqxwrgvepbdj05amlo...@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Hi,
On Mon, Mar 13, 2017 at 11:01 AM, Patrik Flykt
<[email protected]> wrote:
> Yes, do send an update so we can trace down what connman/wpa_supplicant
> think of the error condition.
Coming back to this topic ...
I found a couple of issues in the first version of the patch set,
first I did not considering the "variability" of wpa_supplicant, as I
explain in the new version of the patch, wpa_supplicant does not send
the CurrentBSS at the same state thus all states after associating
must be considered. The other issue is that IWD was also using the
connectable flag, I just removed its use because other issues are
strictly related to the way wpa_supplicant manages the network
profiles and reconnection.
Please check new patch set to know all the details and let me know
what do you think.
Best regards,
Jose Blanquicet
------------------------------
Message: 3
Date: Wed, 21 Jun 2017 15:53:24 +0000
From: Jose Blanquicet <[email protected]>
To: [email protected]
Cc: [email protected], [email protected],
[email protected]
Subject: [PATCH v2 0/6] Avoid to keep service in list if AP is not
found during scan
Message-ID:
<1498060404-20507-1-git-send-email-jose.blanquicet-melen...@magnetimarelli.com>
This patch set does not remove any auto-connect/roaming functionality,
it aims to avoit keeping service in the list after AP deauthenticate
us and it is not found in the scan.
The first patches revert the patches that add the connectable flag and
the use of it because such implementation prevents ConnMan to remove the
service from the services list when it is no longer in range, resulting
in a confusion for users because they will continue seeing a service in
their list when it is not actually available.
Doing so, ConnMan will remove the service once it is no longer in range
and when it comes back wpa_s will notify ConnMan about it through a
"BSSAdded" signal which will allow ConnMan to be prepare for a soon
connection and state machines would continue correctly. In case wpa_s
does not send such signal before notifying we got connected, which
should not happen, the last two patches of this set introduce a
notification named "network_associated" which should handle this border
case.
v2:
- wpa_supplicant could notify about CurrentBSS in any state once it got
associated, i.e. it is not sure such notification will arrive together
with transition to ASSOCIATED state. Therefore, we must consider states:
ASSOCIATED, 4WAY_HANDSHAKE, GROUP_HANDSHAKE, COMPLETED. For instance,
for networks with security WEP or OPEN, it always arrives together with
transition to COMPLETED.
- Connectable flag forces ConnMan to keep service in list even if it
is no longer in range thus do not use it in IWD.
Again, I do not think I could trigger all use cases thus I would
appreciate if people could test auto-connect and roaming use cases.
Mainly auto-connect when AP is who deauthenticates STA.
Patrik, could you please test suspend in your system, thanks!
Jose Blanquicet (6):
iwd: Do not use connectable flag
Revert "device: Use network's connectable flag"
Revert "plugins/wifi: Marking network's Connectable flag as true."
Revert "network: connectable flag in network structure"
gsupplicant: Add callback to notify the associated network
wifi: Set current network in case of reconnection
gsupplicant/gsupplicant.h | 1 +
gsupplicant/supplicant.c | 46 ++++++++++++++++++++++++++
include/network.h | 5 ---
plugins/iwd.c | 2 --
plugins/wifi.c | 83 +++++++++++++++++++++++++++++------------------
src/device.c | 6 +---
src/network.c | 13 --------
7 files changed, 100 insertions(+), 56 deletions(-)
--
1.9.1
------------------------------
Message: 4
Date: Wed, 21 Jun 2017 15:55:03 +0000
From: [email protected]
To: [email protected]
Cc: [email protected], [email protected],
[email protected], Jose Blanquicet
<[email protected]>
Subject: [PATCH v2 1/6] iwd: Do not use connectable flag
Message-ID:
<1498060508-20600-1-git-send-email-jose.blanquicet-melen...@magnetimarelli.com>
From: Jose Blanquicet <[email protected]>
Connectable flag forces ConnMan to keep service in list even if it
is no longer in range.
---
plugins/iwd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/plugins/iwd.c b/plugins/iwd.c
index 8ef9de25258f..b5191654d6cf 100644
--- a/plugins/iwd.c
+++ b/plugins/iwd.c
@@ -203,7 +203,6 @@ static void update_network_connected(struct iwd_network
*iwdn)
static void update_network_disconnected(struct iwd_network *iwdn)
{
DBG("interface name %s", iwdn->name);
- connman_network_set_connectable(iwdn->network, false);
connman_network_set_connected(iwdn->network, false);
}
@@ -243,7 +242,6 @@ static int cm_network_connect(struct connman_network
*network)
g_strdup(iwdn->path), g_free))
return -EIO;
- connman_network_set_connectable(iwdn->network, true);
connman_network_set_associating(iwdn->network, true);
return -EINPROGRESS;
--
1.9.1
------------------------------
Message: 5
Date: Wed, 21 Jun 2017 15:55:04 +0000
From: [email protected]
To: [email protected]
Cc: [email protected], [email protected],
[email protected], Jose Blanquicet
<[email protected]>
Subject: [PATCH v2 2/6] Revert "device: Use network's connectable
flag"
Message-ID:
<1498060508-20600-2-git-send-email-jose.blanquicet-melen...@magnetimarelli.com>
From: Jose Blanquicet <[email protected]>
This reverts commit 9aad337b765dc6ae195e5f21d7764a71b2e82801.
---
src/device.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/src/device.c b/src/device.c
index 471129061c48..a563f4641b90 100644
--- a/src/device.c
+++ b/src/device.c
@@ -671,8 +671,7 @@ static void mark_network_unavailable(gpointer key, gpointer
value,
struct connman_network *network = value;
if (connman_network_get_connected(network) ||
- connman_network_get_connecting(network) ||
- connman_network_get_connectable(network))
+ connman_network_get_connecting(network))
return;
connman_network_set_available(network, false);
@@ -689,9 +688,6 @@ static gboolean remove_unavailable_network(gpointer key,
gpointer value,
if (connman_network_get_available(network))
return FALSE;
- if (connman_network_get_connectable(network))
- return FALSE;
-
return TRUE;
}
--
1.9.1
------------------------------
Message: 6
Date: Wed, 21 Jun 2017 15:55:05 +0000
From: [email protected]
To: [email protected]
Cc: [email protected], [email protected],
[email protected], Jose Blanquicet
<[email protected]>
Subject: [PATCH v2 3/6] Revert "plugins/wifi: Marking network's
Connectable flag as true."
Message-ID:
<1498060508-20600-3-git-send-email-jose.blanquicet-melen...@magnetimarelli.com>
From: Jose Blanquicet <[email protected]>
This reverts commit ff9decb006ba69e83f47401a57cd7f4a5d5ba9f7.
---
plugins/wifi.c | 31 -------------------------------
1 file changed, 31 deletions(-)
diff --git a/plugins/wifi.c b/plugins/wifi.c
index a49031c45faf..fcda4f54fe86 100644
--- a/plugins/wifi.c
+++ b/plugins/wifi.c
@@ -2113,21 +2113,7 @@ static int network_connect(struct connman_network
*network)
wifi->pending_network = network;
g_free(ssid);
} else {
-
- /*
- * This is the network that is going to get plumbed into wpa_s
- * Mark the previous network that is plumbed in wpa_s as not
- * connectable and then the current one as connectable.
- * This flag will be used to ensure that the network that is
- * sitting in wpa_s never gets marked unavailable even though
- * the scan did not find this network.
- */
- if (wifi->network) {
- connman_network_set_connectable(wifi->network, false);
- }
-
wifi->network = connman_network_ref(network);
- connman_network_set_connectable(wifi->network, true);
wifi->retries = 0;
return g_supplicant_interface_connect(interface, ssid,
@@ -2151,7 +2137,6 @@ static void disconnect_callback(int result,
GSupplicantInterface *interface,
}
if (wifi->network) {
- connman_network_set_connectable(wifi->network, false);
connman_network_set_connected(wifi->network, false);
wifi->network = NULL;
}
@@ -2781,22 +2766,6 @@ static void network_removed(GSupplicantNetwork *network)
if (!connman_network)
return;
- /*
- * wpa_s did not find this network in last scan and hence it generated
- * this callback. In case if this is the network with which device
- * was connected to, even though network_removed was called, wpa_s
- * will keep trying to connect to the same network and once the
- * network is back, it will proceed with the connection. Now if
- * connman would have removed this network from network hash table,
- * on a successful connection complete indication service state
- * machine will not move. End result would be only a L2 level
- * connection and no IP address. This check ensures that even if the
- * network_removed gets called for the previously connected network
- * do not remove it from network hash table.
- */
- if (wifi->network == connman_network)
- return;
-
wifi->networks = g_slist_remove(wifi->networks, connman_network);
connman_device_remove_network(wifi->device, connman_network);
--
1.9.1
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 20, Issue 11
***************************************
