Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: WiFi autoscan improvement (Jose Blanquicet)
----------------------------------------------------------------------
Message: 1
Date: Wed, 18 Oct 2017 10:13:31 +0200
From: Jose Blanquicet <[email protected]>
To: Daniel Wagner <[email protected]>,
[email protected]
Cc: [email protected]
Subject: Re: WiFi autoscan improvement
Message-ID:
<cafc8ijlt5w3emg_+sdnzazcg++1hw9mjhsbuq9ijd8ydezz...@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Good morning Raul, Daniel,
On Sun, Oct 15, 2017 at 9:54 PM, Daniel Wagner <[email protected]> wrote:
>> With this patch, connman will be able to perform either a "periodic" or
>> "exponential" autoscan scheme by setting the AUTOSCAN_DEFAULT var as
>> "exponential:xxx:xxx" or "periodic:xxx",
>> exactly same way in which wpa_supplicant (autoscan) can be set on config
>> file. The connman version I use is 1.33.
>
>
> IIRC, there was some discussion on choosing the 'right' values. The periodic
> configuration seems to targeting a different use case.
Interesting. In fact, it would be also useful in our systems.
> I think setting the value via changing the define sounds a bit too hackish
> :) There a couple of ways how we could address this. One way could be going
> via configure.ac. The other is to extend the config parser and allow plugins
> via /etc/connman/wifi.conf (just an example).
I agree, changing the define should not even be an option. Let's think
in something better together :)
- Via configure.ac would imply a recompilation if you want to change
the behaviour, it could not be a problem or maybe yes (?).
- Using a configuration file specific for WiFi sounds good. It would
be initially used only to set this parameter but we have also thought
in other specific WiFi parameters that could use this file to be
configured ;)
- What about main.conf?
I would like to add two comments on the patch:
1. People should not have to modify their code/configuration after
your patch to keep the behaviour the have now. Therefore, the default
behaviour after your patch should remain the same unless you are
proposing a RFC.
2. Patch should consider the case where user entered a wrong value:
+ if (0 == g_strcmp0("exponential", list_params[0])){
+ module = WIFI_AUTOSCAN_EXPONENTIAL;
+ base = atoi(list_params[1]);
+ limit = atoi(list_params[2]);
+ interval = 0;
+ }
+ else if (0 == g_strcmp0("periodic", list_params[0])) {
+ module = WIFI_AUTOSCAN_PERIODIC;
+ base = 0;
+ limit = 0;
+ interval = atoi(list_params[1]);
+ }
+ else {
Here, I would introduce a connman_error("Autoscan configuration %s is
wrong, setting default exponential configuration"), or something like
that in a formalised way. Then, of course set the parameters. @Daniel,
what do you think?
+ g_strfreev(list_params);
+ return NULL;
+ }
Thanks and welcome to the community!
Jose Blanquicet
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 24, Issue 22
***************************************
