Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH] wifi: Don't perform handle_wps_completion() when
p2p is connecting (Jose Blanquicet)
----------------------------------------------------------------------
Message: 1
Date: Thu, 19 Oct 2017 10:24:22 +0200
From: Jose Blanquicet <[email protected]>
To: Saurav Babu <[email protected]>
Cc: [email protected], SACHIN DEV SHARMA <[email protected]>
Subject: Re: [PATCH] wifi: Don't perform handle_wps_completion() when
p2p is connecting
Message-ID:
<CAFC8iJKhbyBvo-Pg7=g=gg1n9cn5mqmrdoy8vum8mjsozaf...@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Hi Saurav,
On Mon, Oct 16, 2017 at 3:54 PM, Saurav Babu <[email protected]> wrote:
> When p2p is connecting and other device acts as Group owner then
> G_SUPPLICANT_STATE_COMPLETED is received after P2P Group formation is
> success. handle_wps_completion() function disconnects the network if
> wps_ssid doesn't match with ssid, due to this reason P2P connection is
> never successful.
Great catch!
> plugins/wifi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/plugins/wifi.c b/plugins/wifi.c
> index 74f216d..a874112 100644
> --- a/plugins/wifi.c
> +++ b/plugins/wifi.c
> @@ -2415,6 +2415,9 @@ static void interface_state(GSupplicantInterface
> *interface)
> /* though it should be already stopped: */
> stop_autoscan(device);
>
> + if (wifi->p2p_connecting)
> + break;
> +
You are testing this with a wpa_supplicant configuration that does not
create a separate P2P group interface, right? Maybe because the
chipset does not support it or that you manually configured
wpa_supplicant to do so (p2p_no_group_iface=1)?
In a system where such group interface is created, IIRC p2p_connecting
will be set only on the main interface and not on the group interface
which is the one that will go to the state
G_SUPPLICANT_STATE_COMPLETED. If that's true, this patch will not
cover such case. Do you agree?
Do you have the possibility to test this with both configuration?
Thanks,
Jose Blanquicet
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 24, Issue 23
***************************************
