Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH] log: Always add a __debug section
(Christian Spielberger)
----------------------------------------------------------------------
Message: 1
Date: Mon, 28 May 2018 12:00:24 +0200
From: Christian Spielberger <[email protected]>
To: Daniel Wagner <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] log: Always add a __debug section
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
On Tue 22.05.18 19:17, Daniel Wagner wrote:
> We want to use the utils code for our tools. Because the utils code
> only uses parts of the logger we need to make sure a __debug section
> always exists otherwise we get an linker error, e.g. "undefined
> reference to `__stop___debug'".
>
> Currently, the __debug section is only added by using DBG(). By adding
> a dummy entry we make sure to have always a __debug section.
> ---
> Hi Christian,
>
> With this change we can drop the tools changes in the first patch of
> your series. I'll update your patch, so no need to resend.
>
> Thanks,
> Daniel
>
> src/log.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/log.c b/src/log.c
> index 9bae4a3d63a3..5deaff83f2a3 100644
> --- a/src/log.c
> +++ b/src/log.c
> @@ -37,6 +37,9 @@
> static const char *program_exec;
> static const char *program_path;
>
> +/* This makes sure we always have a __debug section. */
> +CONNMAN_DEBUG_DEFINE(dummy);
> +
> /**
> * connman_info:
> * @format: format string
> --
> 2.14.3
Ok. Yes, we found that DBG() was necessary (took some time to find this).
Thanks for updating the patch!
regards,
Christian
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 31, Issue 19
***************************************
