Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH 1/2] rtnl: Bail out if interface name is
blacklisted (Peter Meerwald-Stadler)
2. Re: [PATCH v2 1/3] Add macro to determine configuration array
size (Daniel Wagner)
3. [PATCH] main: Rename CONF_AUTO_CONNECT to
CONF_AUTO_CONNECT_TECHS (Daniel Wagner)
----------------------------------------------------------------------
Message: 1
Date: Tue, 5 Jun 2018 00:15:28 +0200 (CEST)
From: Peter Meerwald-Stadler <[email protected]>
To: Daniel Wagner <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH 1/2] rtnl: Bail out if interface name is
blacklisted
Message-ID: <[email protected]>
Content-Type: text/plain; charset=US-ASCII
Hallo Daniel,
> On Wed, May 30, 2018 at 12:29:52AM +0200, Peter Meerwald-Stadler wrote:
> > blacklisting an interface doesn't work for me after
> > commit d81f21e3 (rtnl: retry to add ether interface after renaming)
>
> Can you eleborate a bit what's going on, expecially on the interaction
> with the commit you mentioned?
I want to use connman on eth0, leaving wlan0 alone; so I run
connmand -n -i eth0 -I wlan0
without the patch I'm getting
connmand[24612]: Connection Manager version 1.36
connmand[24612]: lo {newlink} index 1 address 00:00:00:00:00:00 mtu 65536
connmand[24612]: lo {newlink} index 1 operstate 0 <UNKNOWN>
connmand[24612]: eth0 {create} index 2 type 1 <ETHER>
connmand[24612]: eth0 {update} flags 4099 <UP>
connmand[24612]: eth0 {newlink} index 2 address ... mtu 1500
connmand[24612]: eth0 {newlink} index 2 operstate 2 <DOWN>
connmand[24612]: Adding interface eth0 [ ethernet ]
connmand[24612]: wlan0 {create} index 3 type 1 <ETHER>
connmand[24612]: wlan0 {RX} 115682 packets 109444570 bytes
connmand[24612]: wlan0 {TX} 66890 packets 11953734 bytes
connmand[24612]: wlan0 {update} flags 4098 <DOWN>
connmand[24612]: wlan0 {newlink} index 3 address ... mtu 1500
connmand[24612]: wlan0 {newlink} index 3 operstate 2 <DOWN>
connmand[24612]: Ignoring interface wlan0 (filtered)
connmand[24612]: Adding interface wlan0 [ wifi ]
the logging above is rather strange
connmand[24612]: wlan0 {del} route fe80:: gw :: scope 0 <UNIVERSE>
connmand[24612]: wlan0 {del} route fe80:: gw :: scope 0 <UNIVERSE>
connmand[24612]: wlan0 {RX} 115682 packets 109444570 bytes
connmand[24612]: wlan0 {TX} 66890 packets 11953734 bytes
connmand[24612]: wlan0 {newlink} index 3 address ... mtu 1500
connmand[24612]: wlan0 {newlink} index 3 operstate 2 <DOWN>
connmand[24612]: Ignoring interface wlan0 (filtered)
read_uevent() checks if the interface name is blacklisted, but then
continues to open the corresponding uevent file, finds that it is WLAN,
and happily sets SERIVCE_TYPE_WIFI and DEVICE_TYPE_WIFI (nullifying the
blacklisting)
I'm not so sure anymore if it has anything to do with the commit
indicated...
another issue it the rfkill stuff; connman still kills my wifi even though
I have excluded wlan0 -- need to investigate
regards, p.
> > ---
> > src/rtnl.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/src/rtnl.c b/src/rtnl.c
> > index 8080ff01..cba5ef7a 100644
> > --- a/src/rtnl.c
> > +++ b/src/rtnl.c
> > @@ -127,6 +127,7 @@ static void read_uevent(struct interface_data
> > *interface)
> > if (ether_blacklisted(name)) {
> > interface->service_type = CONNMAN_SERVICE_TYPE_UNKNOWN;
> > interface->device_type = CONNMAN_DEVICE_TYPE_UNKNOWN;
> > + goto out;
> > } else {
> > interface->service_type = CONNMAN_SERVICE_TYPE_ETHERNET;
> > interface->device_type = CONNMAN_DEVICE_TYPE_ETHERNET;
>
> Thanks,
> Daniel
>
--
Peter Meerwald-Stadler
Mobile: +43 664 24 44 418
------------------------------
Message: 2
Date: Tue, 5 Jun 2018 08:15:17 +0200
From: Daniel Wagner <[email protected]>
To: Ryan Schaefer <[email protected]>, [email protected]
Cc: Ryan Schaefer <[email protected]>
Subject: Re: [PATCH v2 1/3] Add macro to determine configuration array
size
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Ryan,
I applied all patches.
The commit message in patch #2 was missing a subject line. I added the
one from the first version. Also prefixed the commit message subject.
Furthermore, I moved in patch #1 the define a bit up and changed
CONF_FAVORITE to CONF_FAVORITE_TECHS. Please check if I screwed it up
somehow.
Thanks,
Daniel
------------------------------
Message: 3
Date: Tue, 5 Jun 2018 08:21:52 +0200
From: Daniel Wagner <[email protected]>
To: [email protected]
Cc: Daniel Wagner <[email protected]>
Subject: [PATCH] main: Rename CONF_AUTO_CONNECT to
CONF_AUTO_CONNECT_TECHS
Message-ID: <[email protected]>
Streamline the naming of the define with CONF_AUTO_CONNECT_TECHS,
CONF_FAVORITE_TECHS, CONF_ALWAYS_CONNECTED_TECHS and
CONF_PREFERRED_TECHS.
---
src/main.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/main.c b/src/main.c
index 92ac676c49cb..c8a1bd29c914 100644
--- a/src/main.c
+++ b/src/main.c
@@ -117,7 +117,7 @@ static struct {
#define CONF_BG_SCAN "BackgroundScanning"
#define CONF_PREF_TIMESERVERS "FallbackTimeservers"
-#define CONF_AUTO_CONNECT "DefaultAutoConnectTechnologies"
+#define CONF_AUTO_CONNECT_TECHS "DefaultAutoConnectTechnologies"
#define CONF_FAVORITE_TECHS "DefaultFavoriteTechnologies"
#define CONF_ALWAYS_CONNECTED_TECHS "AlwaysConnectedTechnologies"
#define CONF_PREFERRED_TECHS "PreferredTechnologies"
@@ -140,7 +140,7 @@ static struct {
static const char *supported_options[] = {
CONF_BG_SCAN,
CONF_PREF_TIMESERVERS,
- CONF_AUTO_CONNECT,
+ CONF_AUTO_CONNECT_TECHS,
CONF_ALWAYS_CONNECTED_TECHS,
CONF_PREFERRED_TECHS,
CONF_FALLBACK_NAMESERVERS,
@@ -311,7 +311,7 @@ static void parse_config(GKeyFile *config)
g_clear_error(&error);
str_list = __connman_config_get_string_list(config, "General",
- CONF_AUTO_CONNECT, &len, &error);
+ CONF_AUTO_CONNECT_TECHS, &len, &error);
if (!error)
connman_settings.auto_connect =
@@ -715,7 +715,7 @@ char **connman_setting_get_string_list(const char *key)
unsigned int *connman_setting_get_uint_list(const char *key)
{
- if (g_str_equal(key, CONF_AUTO_CONNECT))
+ if (g_str_equal(key, CONF_AUTO_CONNECT_TECHS))
return connman_settings.auto_connect;
if (g_str_equal(key, CONF_FAVORITE_TECHS))
--
2.14.4
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 32, Issue 3
**************************************
