Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. [PATCH 1/3] technology: Fix various typos in comments
(Peter Meerwald-Stadler)
2. [PATCH 3/3] main: Interface specifier to use or ignore are
actually lists (-i/-I parameter) (Peter Meerwald-Stadler)
3. [PATCH 2/3] doc: Fix some typos (Peter Meerwald-Stadler)
4. [PATCH v2] rtnl: Bail out if interface name is blacklisted
(Peter Meerwald-Stadler)
5. Re: [PATCH 1/2] rtnl: Bail out if interface name is
blacklisted (Peter Meerwald-Stadler)
----------------------------------------------------------------------
Message: 1
Date: Sat, 9 Jun 2018 18:29:58 +0200
From: Peter Meerwald-Stadler <[email protected]>
To: Daniel Wagner <[email protected]>
Cc: [email protected]
Subject: [PATCH 1/3] technology: Fix various typos in comments
Message-ID: <[email protected]>
---
src/technology.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/technology.c b/src/technology.c
index 4c1cbbbb..f25be12f 100644
--- a/src/technology.c
+++ b/src/technology.c
@@ -100,7 +100,7 @@ static void rfkill_check(gpointer key, gpointer value,
gpointer user_data)
struct connman_rfkill *rfkill = value;
enum connman_service_type type = GPOINTER_TO_INT(user_data);
- /* Calling _technology_rfkill_add will update the tech. */
+ /* Calling _technology_add_rfkill will update the tech. */
if (rfkill->type == type)
__connman_technology_add_rfkill(rfkill->index, type,
rfkill->softblock, rfkill->hardblock);
@@ -620,7 +620,7 @@ static gboolean technology_pending_reply(gpointer user_data)
struct connman_technology *technology = user_data;
DBusMessage *reply;
- /* Power request timedout, send ETIMEDOUT. */
+ /* Power request timed out, send ETIMEDOUT. */
if (technology->pending_reply) {
reply = __connman_error_failed(technology->pending_reply,
ETIMEDOUT);
if (reply)
@@ -1474,7 +1474,7 @@ int __connman_technology_add_device(struct connman_device
*device)
int err = __connman_device_enable(device);
/*
* connman_technology_add_device() calls
__connman_device_enable()
- * but since the device is already enabled, the calls does not
+ * but since the device is already enabled, the call does not
* propagate through to connman_technology_enabled via
* connman_device_set_powered.
*/
@@ -1578,7 +1578,7 @@ int __connman_technology_set_offlinemode(bool offlinemode)
* resuming offlinemode from last saved profile. We need that
* information in rfkill_update, otherwise it falls back on the
* technology's persistent state. Hence we set the offline mode here
- * but save it & call the notifier only if its successful.
+ * but save it & call the notifier only if it is successful.
*/
global_offlinemode = offlinemode;
--
2.17.1
------------------------------
Message: 2
Date: Sat, 9 Jun 2018 18:30:00 +0200
From: Peter Meerwald-Stadler <[email protected]>
To: Daniel Wagner <[email protected]>
Cc: [email protected]
Subject: [PATCH 3/3] main: Interface specifier to use or ignore are
actually lists (-i/-I parameter)
Message-ID: <[email protected]>
Correctly indicate in the help text that one can give list of
devices/interfaces with the -i/-I parameter.
change connmand -h from
-i, --device=DEV Specify networking device or interface
-I, --nodevice=DEV Specify networking interface to ignore
to
-i, --device=DEV,... Specify networking devices or interfaces
-I, --nodevice=DEV,... Specify networking interfaces to ignore
---
src/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/main.c b/src/main.c
index 92ac676c..3f8221eb 100644
--- a/src/main.c
+++ b/src/main.c
@@ -623,9 +623,9 @@ static GOptionEntry options[] = {
G_OPTION_ARG_CALLBACK, parse_debug,
"Specify debug options to enable", "DEBUG" },
{ "device", 'i', 0, G_OPTION_ARG_STRING, &option_device,
- "Specify networking device or interface", "DEV" },
+ "Specify networking devices or interfaces", "DEV,..." },
{ "nodevice", 'I', 0, G_OPTION_ARG_STRING, &option_nodevice,
- "Specify networking interface to ignore", "DEV" },
+ "Specify networking interfaces to ignore", "DEV,..." },
{ "plugin", 'p', 0, G_OPTION_ARG_STRING, &option_plugin,
"Specify plugins to load", "NAME,..." },
{ "noplugin", 'P', 0, G_OPTION_ARG_CALLBACK, &parse_noplugin,
--
2.17.1
------------------------------
Message: 3
Date: Sat, 9 Jun 2018 18:29:59 +0200
From: Peter Meerwald-Stadler <[email protected]>
To: Daniel Wagner <[email protected]>
Cc: [email protected]
Subject: [PATCH 2/3] doc: Fix some typos
Message-ID: <[email protected]>
---
doc/connmanctl.1.in | 2 +-
doc/plugin-api.txt | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/connmanctl.1.in b/doc/connmanctl.1.in
index 0f891bd0..47d9c303 100644
--- a/doc/connmanctl.1.in
+++ b/doc/connmanctl.1.in
@@ -180,7 +180,7 @@ Configures the IPv6 settings for the service. The argument
settings will be asked from the network and \fBmanual\fR means
that the given arguments will be used as IPv6 settings.
.IR address " and " gateway
-must be valid IPv4 addresses. \fIprefixlength\fR is the length
+must be valid IPv6 addresses. \fIprefixlength\fR is the length
of the prefix in bits. See the \fBEXAMPLE\fR section of this man
page for details.
.PP
diff --git a/doc/plugin-api.txt b/doc/plugin-api.txt
index ea5ec0a1..36391e96 100644
--- a/doc/plugin-api.txt
+++ b/doc/plugin-api.txt
@@ -6,7 +6,7 @@ Plugin basics
=============
The Connection Manager supports plugins for various actions. The basic plugin
-contains of plugin description via CONNMAN_PLUGIN_DEFINE and also init/exit
+contains a plugin description via CONNMAN_PLUGIN_DEFINE and also init/exit
callbacks defined through that description.
#include <connman/plugin.h>
--
2.17.1
------------------------------
Message: 4
Date: Sat, 9 Jun 2018 19:19:18 +0200
From: Peter Meerwald-Stadler <[email protected]>
To: Daniel Wagner <[email protected]>
Cc: [email protected]
Subject: [PATCH v2] rtnl: Bail out if interface name is blacklisted
Message-ID: <[email protected]>
read_uevent() checks if the interface name is blacklisted, but then
continues to open the corresponding uevent file, and happily sets SERIVCE_TYPE
and DEVICE_TYPE (nullifying the blacklisting)
this leads to the following logging when starting connmand -I wlan0
Ignoring interface wlan0 (filtered)
Adding interface wlan0 [ wifi ]
fix this by bailing out from read_uevent() as soon as we find the device
is blacklisted
---
src/rtnl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/rtnl.c b/src/rtnl.c
index 8080ff01..cba5ef7a 100644
--- a/src/rtnl.c
+++ b/src/rtnl.c
@@ -127,6 +127,7 @@ static void read_uevent(struct interface_data *interface)
if (ether_blacklisted(name)) {
interface->service_type = CONNMAN_SERVICE_TYPE_UNKNOWN;
interface->device_type = CONNMAN_DEVICE_TYPE_UNKNOWN;
+ goto out;
} else {
interface->service_type = CONNMAN_SERVICE_TYPE_ETHERNET;
interface->device_type = CONNMAN_DEVICE_TYPE_ETHERNET;
--
2.17.1
------------------------------
Message: 5
Date: Sat, 9 Jun 2018 19:19:26 +0200 (CEST)
From: Peter Meerwald-Stadler <[email protected]>
To: Daniel Wagner <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH 1/2] rtnl: Bail out if interface name is
blacklisted
Message-ID: <[email protected]>
Content-Type: text/plain; charset=US-ASCII
Hello,
> > On Wed, May 30, 2018 at 12:29:52AM +0200, Peter Meerwald-Stadler wrote:
> > > blacklisting an interface doesn't work for me after
> > > commit d81f21e3 (rtnl: retry to add ether interface after renaming)
> >
> > Can you eleborate a bit what's going on, expecially on the interaction
> > with the commit you mentioned?
>
> I want to use connman on eth0, leaving wlan0 alone; so I run
> connmand -n -i eth0 -I wlan0
>
> without the patch I'm getting
>
> connmand[24612]: Connection Manager version 1.36
> connmand[24612]: lo {newlink} index 1 address 00:00:00:00:00:00 mtu 65536
> connmand[24612]: lo {newlink} index 1 operstate 0 <UNKNOWN>
> connmand[24612]: eth0 {create} index 2 type 1 <ETHER>
> connmand[24612]: eth0 {update} flags 4099 <UP>
> connmand[24612]: eth0 {newlink} index 2 address ... mtu 1500
> connmand[24612]: eth0 {newlink} index 2 operstate 2 <DOWN>
> connmand[24612]: Adding interface eth0 [ ethernet ]
> connmand[24612]: wlan0 {create} index 3 type 1 <ETHER>
> connmand[24612]: wlan0 {RX} 115682 packets 109444570 bytes
> connmand[24612]: wlan0 {TX} 66890 packets 11953734 bytes
> connmand[24612]: wlan0 {update} flags 4098 <DOWN>
> connmand[24612]: wlan0 {newlink} index 3 address ... mtu 1500
> connmand[24612]: wlan0 {newlink} index 3 operstate 2 <DOWN>
> connmand[24612]: Ignoring interface wlan0 (filtered)
> connmand[24612]: Adding interface wlan0 [ wifi ]
>
> the logging above is rather strange
>
> connmand[24612]: wlan0 {del} route fe80:: gw :: scope 0 <UNIVERSE>
> connmand[24612]: wlan0 {del} route fe80:: gw :: scope 0 <UNIVERSE>
> connmand[24612]: wlan0 {RX} 115682 packets 109444570 bytes
> connmand[24612]: wlan0 {TX} 66890 packets 11953734 bytes
> connmand[24612]: wlan0 {newlink} index 3 address ... mtu 1500
> connmand[24612]: wlan0 {newlink} index 3 operstate 2 <DOWN>
> connmand[24612]: Ignoring interface wlan0 (filtered)
>
> read_uevent() checks if the interface name is blacklisted, but then
> continues to open the corresponding uevent file, finds that it is WLAN,
> and happily sets SERIVCE_TYPE_WIFI and DEVICE_TYPE_WIFI (nullifying the
> blacklisting)
submitting a V2 of the patch with updated description
> I'm not so sure anymore if it has anything to do with the commit
> indicated...
> another issue it the rfkill stuff; connman still kills my wifi even though
> I have excluded wlan0 -- need to investigate
this one I solved: just disable the corresponding technology plugin, so
e.g. wifi gets disabled together with rfkills of type wifi
rfkill devices are only matched by technology (and not per device), so
fine grained control is not easily achieved
p.
> > > ---
> > > src/rtnl.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/src/rtnl.c b/src/rtnl.c
> > > index 8080ff01..cba5ef7a 100644
> > > --- a/src/rtnl.c
> > > +++ b/src/rtnl.c
> > > @@ -127,6 +127,7 @@ static void read_uevent(struct interface_data
> > > *interface)
> > > if (ether_blacklisted(name)) {
> > > interface->service_type = CONNMAN_SERVICE_TYPE_UNKNOWN;
> > > interface->device_type = CONNMAN_DEVICE_TYPE_UNKNOWN;
> > > + goto out;
> > > } else {
> > > interface->service_type = CONNMAN_SERVICE_TYPE_ETHERNET;
> > > interface->device_type = CONNMAN_DEVICE_TYPE_ETHERNET;
> >
> > Thanks,
> > Daniel
> >
>
>
--
Peter Meerwald-Stadler
Mobile: +43 664 24 44 418
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 32, Issue 4
**************************************
