Send connman mailing list submissions to
        [email protected]

To subscribe or unsubscribe via the World Wide Web, visit
        https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
        [email protected]

You can reach the person managing the list at
        [email protected]

When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."


Today's Topics:

   1. Error "wifi: No carrier" only to connman (Jun Nie)
   2. break instead of continue in
      __connman_service_disconnect_all()? (Henrik Persson)


----------------------------------------------------------------------

Message: 1
Date: Tue, 5 Mar 2019 12:25:28 +0800
From: Jun Nie <[email protected]>
To: [email protected]
Subject: Error "wifi: No carrier" only to connman
Message-ID:
        <CABymUCP3TXq2mMqTknmFisMFmQ+iykc=+44vxjhe73imx8k...@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"

Hi,

I always see this issue after board boot up. After disable/enable
wifi, wait for several minutes, then disable/enable wifi, it works. It
is not due to rfkill or kernel driver issue, because "iwlist wlan0
scan" command works well after board boot up while connmanctl has
issue. Does anyone happen to know this issue? The version is 1.36 with
some patches at:
https://github.com/openembedded/openembedded-core/tree/master/meta/recipes-connectivity/connman/connman

Best Regards.
Jun


------------------------------

Message: 2
Date: Tue, 5 Mar 2019 10:03:47 +0000
From: Henrik Persson <[email protected]>
To: "[email protected]" <[email protected]>
Subject: break instead of continue in
        __connman_service_disconnect_all()?
Message-ID:
        
<he1pr1001mb12266593f6381ad1afa97a17f7...@he1pr1001mb1226.eurprd10.prod.outlook.com>
        
Content-Type: text/plain; charset="iso-8859-1"


Hi connman-list!


Reading through the code trying to debug another issue I stumbled upon what I 
think is a bug
in __connman_service_disconnect_all(). It doesn't seem to be used anywhere, 
but..still seems
like the break in that for loop is not doing what you want it to do if you're 
supposed to disconnect
all connected services.

diff --git a/src/service.c b/src/service.c
index f6fe81bf..ffaebcc3 100644
--- a/src/service.c
+++ b/src/service.c
@@ -6536,7 +6536,7 @@ int __connman_service_disconnect_all(void)
                service = iter->data;
 
                if (!is_connected(service->state))
-                       break;
+                       continue;
 
                services = g_slist_prepend(services, service);
        }


--
Kind regards,
Henrik Persson
Verisure Innovation AB

------------------------------

Subject: Digest Footer

_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman


------------------------------

End of connman Digest, Vol 41, Issue 4
**************************************

Reply via email to