Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH v2 0/5] Include VPNs in service.c autoconnect
process. (Jussi Laakkonen)
2. Re: [PATCH v2 0/5] Include VPNs in service.c autoconnect
process. (Daniel Wagner)
3. [PATCH v2 5/5] service: Call vpn_auto_connect() when default
service changes. (Jussi Laakkonen)
4. Re: Why can't connman automatically enable and connect to
cellular network interface? (Tarmo Kuuse)
5. [PATCH] vpn: Follow coding style M12 in enum switch and fix
debug log msg (Jussi Laakkonen)
6. Re: Why can't connman automatically enable and connect to
cellular network interface? (JH)
7. Re: Why can't connman automatically enable and connect to
cellular network interface? (JH)
----------------------------------------------------------------------
Message: 1
Date: Thu, 25 Apr 2019 10:14:17 +0300
From: Jussi Laakkonen <[email protected]>
To: Daniel Wagner <[email protected]>, [email protected]
Subject: Re: [PATCH v2 0/5] Include VPNs in service.c autoconnect
process.
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Daniel,
On 4/25/19 10:08 AM, Daniel Wagner wrote:
> Hi Jussi,
>
> On 4/24/19 11:46 AM, Jussi Laakkonen wrote:
>> Changes since v2:
>> ? * Patch 0/5: Update "Fourth" description.
>> ? * Patch 3/5: Remove unnecessary debug logging.
>> ? * Patch 4/5:
>> ??? * Conform to formatting rules.
>> ??? * Modify comments to be more simple and put more info to commit msg.
>> ??? * Update commit message to be more coherent and understandable.
>
> Patches #1 to #4 applied.
Oh, I'll just update #5 then :)
>
> Thanks,
> Daniel
Cheers,
Jussi
------------------------------
Message: 2
Date: Thu, 25 Apr 2019 09:25:40 +0200
From: Daniel Wagner <[email protected]>
To: Jussi Laakkonen <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH v2 0/5] Include VPNs in service.c autoconnect
process.
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
>> Patches #1 to #4 applied.
>
> Oh, I'll just update #5 then :)
No worries, shit happends :)
Thanks!
------------------------------
Message: 3
Date: Thu, 25 Apr 2019 10:27:24 +0300
From: Jussi Laakkonen <[email protected]>
To: [email protected]
Subject: [PATCH v2 5/5] service: Call vpn_auto_connect() when default
service changes.
Message-ID: <[email protected]>
This commit adds call to vpn_auto_connect() when default service changes
and the service is not a VPN service. With this change it is ensured
that VPNs are being autoconnected when the default network changes.
---
Changes since v2:
* Move vpn_auto_connect() function prototype to top.
src/service.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/src/service.c b/src/service.c
index e9901d02..7f09edc1 100644
--- a/src/service.c
+++ b/src/service.c
@@ -148,6 +148,7 @@ static struct connman_ipconfig *create_ip4config(struct
connman_service *service
static struct connman_ipconfig *create_ip6config(struct connman_service
*service,
int index);
static void dns_changed(struct connman_service *service);
+static void vpn_auto_connect(void);
struct find_data {
const char *path;
@@ -1593,6 +1594,16 @@ static void default_changed(void)
if (service->domainname &&
connman_setting_get_bool("AllowDomainnameUpdates"))
__connman_utsname_set_domainname(service->domainname);
+
+ /*
+ * Connect VPN automatically when new default service
+ * is set and connected, unless new default is VPN
+ */
+ if (is_connected(service->state) &&
+ service->type != CONNMAN_SERVICE_TYPE_VPN) {
+ DBG("running vpn_auto_connect");
+ vpn_auto_connect();
+ }
}
__connman_notifier_default_changed(service);
@@ -3413,8 +3424,6 @@ error:
return -EINVAL;
}
-static void vpn_auto_connect(void);
-
static void do_auto_connect(struct connman_service *service,
enum connman_service_connect_reason reason)
{
--
2.20.1
------------------------------
Message: 4
Date: Thu, 25 Apr 2019 10:32:42 +0300
From: Tarmo Kuuse <[email protected]>
To: [email protected]
Subject: Re: Why can't connman automatically enable and connect to
cellular network interface?
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
On 25.04.19 09:56, Daniel Wagner wrote:
>> Basically the auto connect does not work. At first time boot up, the
>> connman does not perform auto connect, I tried to deploy both wifi
>> (with SSID and Passphrase) and cellular settings to /var/lib/connman,
>> the connman still could not detect the wifi and cellular until I
>> perform manual configuration via connmanctl.
>
> In the other mail you mentioned this. Though looking at the paths/file
> names it looked wrong. The provisioning files life just under
> /var/lib/connman and not in /var/lib/connman/$id/settings. Only files
> under /var/lib/connman/$name.config will be monitored by ConnMan.
Where would I look to understand these provisioning files? The
"main.conf" is nicely documented by the Debian manpages, but the stuff
in "/var/lib/connman" is not. I'd settle for reading code, just need a
hint of where to start.
--
Kind regards
Tarmo
------------------------------
Message: 5
Date: Thu, 25 Apr 2019 11:03:10 +0300
From: Jussi Laakkonen <[email protected]>
To: [email protected]
Subject: [PATCH] vpn: Follow coding style M12 in enum switch and fix
debug log msg
Message-ID: <[email protected]>
This commit modifies 2ba4926433585b337aff8beeb0285b55e3d22468 switch to
follow coding style M12. With enum's "default" should not be used.
Also, add space to vpn.c:vpn_disconnect() debug log message to separate
words in output.
---
vpn/plugins/vpn.c | 2 +-
vpn/vpn-provider.c | 5 ++++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/vpn/plugins/vpn.c b/vpn/plugins/vpn.c
index 38aa3a7e..ddf4a6c6 100644
--- a/vpn/plugins/vpn.c
+++ b/vpn/plugins/vpn.c
@@ -555,7 +555,7 @@ static int vpn_disconnect(struct vpn_provider *provider)
data->state = VPN_STATE_DISCONNECT;
if (!vpn_driver_data->vpn_driver->disconnect) {
- DBG("Driver has no disconnect() implementation, set provider"
+ DBG("Driver has no disconnect() implementation, set provider "
"state to disconnect.");
vpn_provider_set_state(provider, VPN_PROVIDER_STATE_DISCONNECT);
}
diff --git a/vpn/vpn-provider.c b/vpn/vpn-provider.c
index c3df20b0..3f049e60 100644
--- a/vpn/vpn-provider.c
+++ b/vpn/vpn-provider.c
@@ -1119,7 +1119,10 @@ int __vpn_provider_connect(struct vpn_provider
*provider, DBusMessage *msg)
*/
case VPN_PROVIDER_STATE_DISCONNECT:
return -EINPROGRESS;
- default:
+ case VPN_PROVIDER_STATE_UNKNOWN:
+ case VPN_PROVIDER_STATE_IDLE:
+ case VPN_PROVIDER_STATE_CONNECT:
+ case VPN_PROVIDER_STATE_READY:
break;
}
--
2.20.1
------------------------------
Message: 6
Date: Thu, 25 Apr 2019 18:28:46 +1000
From: JH <[email protected]>
To: Daniel Wagner <[email protected]>
Cc: Christophe Ronco <[email protected]>, [email protected]
Subject: Re: Why can't connman automatically enable and connect to
cellular network interface?
Message-ID:
<CAA=hcWQJYb3tpf4vt2Q7svgRT1rgTuzUqmhi=iq6vdtzpra...@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Hi Daniel,
> In the other mail you mentioned this. Though looking at the paths/file
> names it looked wrong. The provisioning files life just under
> /var/lib/connman and not in /var/lib/connman/$id/settings. Only files
> under /var/lib/connman/$name.config will be monitored by ConnMan.
I did try to use the $name.config, it did not work either, did I get
wrong with the $name?
$ cat /var/lib/connman/tpg-mcnf.conf
[service_wifi]
Name=TPG-MCNF
SSID=5450472d4d434e44
Passphrase=xxxxxx
AutoConnect=true
$ cat /var/lib/connman/telstra.conf
[cellular_505013520350165_context1]
Name=Telstra
Favorite=true
AutoConnect=true
Tarmo: You can find format and information in doc/config-format.txt.
Thank you.
- jupiter
------------------------------
Message: 7
Date: Thu, 25 Apr 2019 18:56:32 +1000
From: JH <[email protected]>
To: Daniel Wagner <[email protected]>
Cc: Christophe Ronco <[email protected]>, [email protected]
Subject: Re: Why can't connman automatically enable and connect to
cellular network interface?
Message-ID:
<CAA=hcWQXEBhfd+eHOU2Eo7JO9DezWb=cm8wjggqwiulauem...@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sorry, type the wrong config file name, it is tpg-mcnf.config and
telstra.config, tried to change both to wifi.config and
celluar.config, no avail either.
On 4/25/19, JH <[email protected]> wrote:
> Hi Daniel,
>
>> In the other mail you mentioned this. Though looking at the paths/file
>> names it looked wrong. The provisioning files life just under
>> /var/lib/connman and not in /var/lib/connman/$id/settings. Only files
>> under /var/lib/connman/$name.config will be monitored by ConnMan.
>
> I did try to use the $name.config, it did not work either, did I get
> wrong with the $name?
>
> $ cat /var/lib/connman/tpg-mcnf.conf
> [service_wifi]
> Name=TPG-MCNF
> SSID=5450472d4d434e44
> Passphrase=xxxxxx
> AutoConnect=true
>
> $ cat /var/lib/connman/telstra.conf
> [cellular_505013520350165_context1]
> Name=Telstra
> Favorite=true
> AutoConnect=true
>
> Tarmo: You can find format and information in doc/config-format.txt.
>
> Thank you.
>
> - jupiter
>
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 42, Issue 22
***************************************
