Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH v2 5/5] service: Call vpn_auto_connect() when
default service changes. (Daniel Wagner)
2. Re: [PATCH] vpn: Follow coding style M12 in enum switch and
fix debug log msg (Daniel Wagner)
3. [PATCH 0/2] Annotate case statements (Daniel Wagner)
4. [PATCH 1/2] service: Annotate case statement with fall
through (Daniel Wagner)
5. [PATCH 2/2] vpn: Annotate case statement with fall through
(Daniel Wagner)
6. Re: [PATCH 0/2] Annotate case statements (Daniel Wagner)
7. Re: Why can't connman automatically enable and connect to
cellular network interface? (Tarmo Kuuse)
8. Re: Why can't connman automatically enable and connect to
cellular network interface? (JH)
----------------------------------------------------------------------
Message: 1
Date: Thu, 25 Apr 2019 21:01:29 +0200
From: Daniel Wagner <[email protected]>
To: Jussi Laakkonen <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH v2 5/5] service: Call vpn_auto_connect() when
default service changes.
Message-ID: <20190425190129.ic4obqmjlxg5lend@beryllium>
Content-Type: text/plain; charset=us-ascii
Hi Jussi,
On Thu, Apr 25, 2019 at 10:27:24AM +0300, Jussi Laakkonen wrote:
> This commit adds call to vpn_auto_connect() when default service changes
> and the service is not a VPN service. With this change it is ensured
> that VPNs are being autoconnected when the default network changes.
Patch applied.
Thanks!
Daniel
------------------------------
Message: 2
Date: Thu, 25 Apr 2019 21:03:10 +0200
From: Daniel Wagner <[email protected]>
To: Jussi Laakkonen <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] vpn: Follow coding style M12 in enum switch and
fix debug log msg
Message-ID: <20190425190310.vx6bbznaq4lpa55k@beryllium>
Content-Type: text/plain; charset=us-ascii
Hi Jussi,
On Thu, Apr 25, 2019 at 11:03:10AM +0300, Jussi Laakkonen wrote:
> This commit modifies 2ba4926433585b337aff8beeb0285b55e3d22468 switch to
> follow coding style M12. With enum's "default" should not be used.
>
> Also, add space to vpn.c:vpn_disconnect() debug log message to separate
> words in output.
Patch applied.
Thanks,
Daniel
------------------------------
Message: 3
Date: Thu, 25 Apr 2019 21:18:14 +0200
From: Daniel Wagner <[email protected]>
To: [email protected]
Cc: Daniel Wagner <[email protected]>
Subject: [PATCH 0/2] Annotate case statements
Message-ID: <[email protected]>
GCC is complaining.
Daniel Wagner (2):
service: Annotate case statement with fall through
vpn: Annotate case statement with fall through
src/service.c | 1 +
vpn/vpn-provider.c | 1 +
2 files changed, 2 insertions(+)
--
2.20.1
------------------------------
Message: 4
Date: Thu, 25 Apr 2019 21:18:15 +0200
From: Daniel Wagner <[email protected]>
To: [email protected]
Cc: Daniel Wagner <[email protected]>
Subject: [PATCH 1/2] service: Annotate case statement with fall
through
Message-ID: <[email protected]>
gcc complains with 'this statement may fall through' for
4a41763bee38 ("service: Indicate service state when autoconnect
succeeds").
This is not an error, so annotate it accordingly.
---
src/service.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/service.c b/src/service.c
index a728de2fb4d4..1f9b5ba5194d 100644
--- a/src/service.c
+++ b/src/service.c
@@ -4313,6 +4313,7 @@ static gboolean run_vpn_auto_connect(gpointer data) {
switch (res) {
case 0:
service_indicate_state(service);
+ /* fall through */
case -EINPROGRESS:
autoconnectable_vpns = true;
break;
--
2.20.1
------------------------------
Message: 5
Date: Thu, 25 Apr 2019 21:18:16 +0200
From: Daniel Wagner <[email protected]>
To: [email protected]
Cc: Daniel Wagner <[email protected]>
Subject: [PATCH 2/2] vpn: Annotate case statement with fall through
Message-ID: <[email protected]>
gcc complains with 'this statement may fall through' for
2ba492643358 ("vpn: Let previous connection to finish before starting
new one").
This is not an error, so annotate it accordingly.
---
vpn/vpn-provider.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/vpn/vpn-provider.c b/vpn/vpn-provider.c
index 3f049e6062d5..ce8dc29de746 100644
--- a/vpn/vpn-provider.c
+++ b/vpn/vpn-provider.c
@@ -1109,6 +1109,7 @@ int __vpn_provider_connect(struct vpn_provider *provider,
DBusMessage *msg)
*/
case VPN_PROVIDER_STATE_FAILURE:
vpn_provider_set_state(provider, VPN_PROVIDER_STATE_IDLE);
+ /* fall through */
/*
* If re-using a provider and it is being disconnected let it finish
* the disconnect process in order to let vpn.c:vpn_died() to get
--
2.20.1
------------------------------
Message: 6
Date: Thu, 25 Apr 2019 21:20:15 +0200
From: Daniel Wagner <[email protected]>
To: [email protected]
Subject: Re: [PATCH 0/2] Annotate case statements
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Both patches applied.
------------------------------
Message: 7
Date: Fri, 26 Apr 2019 11:17:09 +0300
From: Tarmo Kuuse <[email protected]>
To: [email protected]
Subject: Re: Why can't connman automatically enable and connect to
cellular network interface?
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Jupiter,
On 25.04.19 11:28, JH wrote:
> I did try to use the $name.config, it did not work either, did I get
> wrong with the $name?
>
> $ cat /var/lib/connman/tpg-mcnf.conf
> [service_wifi]
> Name=TPG-MCNF
> SSID=5450472d4d434e44
> Passphrase=xxxxxx
> AutoConnect=true
>
> $ cat /var/lib/connman/telstra.conf
> [cellular_505013520350165_context1]
> Name=Telstra
> Favorite=true
> AutoConnect=true
>
> Tarmo: You can find format and information in doc/config-format.txt.
Thanks!
BTW: you've used ".conf" suffix but the document mandates ".config".
Regardless, connman v1.36 certainly doesn't follow the file structure
described in doc/config-format.txt. After manually provisioning my
dial-up connection I can see directories:
/var/lib/connman/cellular_248030054743345_context1/
/var/lib/connman/ethernet_00e04c2154c3_cable/
Both contain two files "data" and "settings". Here's a "settings" file,
which does what you're looking to do - start the dial-up on boot.
--- begin ---
[cellular_248030054743345_context1]
Name=Tele2 EE
Favorite=true
AutoConnect=true
Modified=2019-04-22T12:57:30.161163Z
IPv4.method=fixed
IPv4.netmask_prefixlen=32
IPv4.local_address=[...snip...]
IPv6.method=off
IPv6.privacy=disabled
--- end ---
The "data" file contains some garbage which I don't recognize.
Anyway, the service name and configuration format revolve around the
IMSI of the SIM card. Does this mean that I can only pre-provision a
cellular service if I know in advance the IMSI of the SIM card to be used?
--
Kind regards
Tarmo
------------------------------
Message: 8
Date: Fri, 26 Apr 2019 20:08:19 +1000
From: JH <[email protected]>
To: Tarmo Kuuse <[email protected]>
Cc: [email protected]
Subject: Re: Why can't connman automatically enable and connect to
cellular network interface?
Message-ID:
<CAA=hcwrv3w7_ekvaep5u1trpr+qobqeqaobb3hywxtmpsry...@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Hi Tarmo,
> BTW: you've used ".conf" suffix but the document mandates ".config".
Yeap, I sent another email to correct my typo.
> Regardless, connman v1.36 certainly doesn't follow the file structure
> described in doc/config-format.txt. After manually provisioning my
> dial-up connection I can see directories:
>
> /var/lib/connman/cellular_248030054743345_context1/
> /var/lib/connman/ethernet_00e04c2154c3_cable/
>
> Both contain two files "data" and "settings". Here's a "settings" file,
> which does what you're looking to do - start the dial-up on boot.
That is the normal connman set up, I think what Daniel and document
said was if you deploy a file ${name}.config to /var/lib/connman, the
connman daemon will be notified and auto connect those services
without manual configuration that what embedded systems require. But
the auto connect feature does not seem work, Daniel is busy.
Daniel, if you could let me know that is the issue to cause auto
connect not working, where to look, I will try it.
Thank you.
Kind regards,
- jupiter
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 42, Issue 23
***************************************
