https://bugs.contribs.org/show_bug.cgi?id=9888
--- Comment #13 from Jean-Philippe Pialasse <[email protected]> ---
Brian,
first thank for your patience and effort... you can skip to the end if you want
the short answer and solution...
(In reply to Brian Read from comment #11)
> Created attachment 5740 [details]
> Screen capture of thunderbird mailstats email.
>
> Here's a screen capture of my thunderbird, on the same tables.
>
> Must be some local config?
ok, let's assume this is because of my french locale and me launching it from
CLI.
(In reply to Brian Read from comment #12)
> (In reply to Brian Read from comment #8)
> > (In reply to Jean-Philippe Pialasse from comment #7)
> > > almost perfect :
> > > the table displays now at the end but the following text under the first
> > > table is still absent:
> > >
> > > *Geoip.*:Bad Countries mask is:*none*
> > >
> > > >
> > > (side note maybe some \t have to be added to align colum title with
> > > numbers)
> >
> > The code does not show the Geoip mask if it is empty.
> >
>
> Unless there are exclusion messages in the logs OR an exclusion mask, the
> script is not aware that geoip has been installed. I could query the rpm DB,
> but that seems a bit over the top.
well I agree with you that it is not needed to check more the db.
What I am saying there is that in the previous version I was using
/usr/bin/spamfilter-stats-7.pl Version : 0.6.29
I had the following message under the first table :
*Local* means connections from workstations on local LAN.
*Non.Conf.* means sending mailserver did not conform to correct protocol or
email was to non existant address.
*Geoip.*:Bad Countries mask is:*none*
and now I get
*Local* means connections from workstations on local LAN.
*Non.Conf.* means sending mailserver did not conform to correct protocol or
email was to non existant address.
without any other modification than updating to the next versions : 0.7.10 or
0.7.11
so on line 1118 :
if ($finaldisplay[$BadCountryCateg]){
$BadCountries = $cdb->get('qpsmtpd')->prop('BadCountries') ||
"*none*";
print "*Geoip\.*:Bad Countries mask
is:".$BadCountries."\n\n";
}
is not printing anymore in my case with *none* while it did ...
while on line 1233, now that you changed the conditions
if ($enableGeoiptable and (($total_countries > 0) or
$finaldisplay[$BadCountryCateg])){show_Geoip_results();}
this print the table.
SO from my point of view either the line 1118 need the same modification,
either we need to understand what changed ( maybe a bug that I thought to be a
feature and you fixed it ;) ) and make the previous code not showing geoip
warning text and table.
maybe this is only the changing from
my $BadCountryCateg=8; #Careful here this number could change if more added
before.
to
my $BadCountryCateg=9;
that could have made some break in the logic.
but from what I see I have Geoip.=yes in configuraiton db
so if ($display[$ncateg] eq 'yes') { $finaldisplay[$ncateg] = $true } for geoip
so I did some more diging , and it seems the magic number for the category ( in
parenthesis) is not right :
Fetchmail(1):
WebMail(2): 1
Mailman(3):
Local(4): 1
Relay(5): 1
DMARC Rej.(6):
Virus(7): 1
RBL/DNS(8): 1
Execut.(9):
Geoip.(10): 1
Non.Conf.(11): 1
Rej.Load(12):
Karma(13):
Del.Spam(14): 1
Qued.Spam?(15): 1
Ham(16): 1
used the following around line 1022, before the $ncateg++ line :
print $categs[$ncateg] . "($ncateg)". ": " . $finaldisplay[$ncateg] ."\n";
but you can also see that it is the 11th in the array here on line 188:
my @categs =
($CATHOUR,$CATFETCHMAIL,$CATWEBMAIL,$CATMAILMAN,$CATLOCAL,$CATRELAY,$CATDMARC,$CATVIRUS,$CATRBLDNS,$CATEXECUT,$CATBADCOUNTRIES,$CATNONCONF,$CATLOAD,$CATKARMA,$CATSPAMDEL,$CATSPAM,$CATHAM,$CATTOTALS,$CATPERCENT);
so you might want to update from 9 to 10
my $BadCountryCateg=9;
and also to check if still correct but I would guess it is ok as is:
my $KarmaCateg=$BadCountryCateg+3;
and finally reverse your last addition "and (($total_countries > 0) or
$finaldisplay[$BadCountryCateg])"
--
You are receiving this mail because:
You are the QA Contact for the bug._______________________________________________
Mail for each SME Contribs bug report
To unsubscribe, e-mail [email protected]
Searchable archive at https://lists.contribs.org/mailman/public/contribteam/
