https://bugs.contribs.org/show_bug.cgi?id=10357

--- Comment #4 from Jean-Philippe Pialasse <te...@pialasse.com> ---
(In reply to John Crisp from comment #3)
> OK,
> 
> I'd propose the following:
> 
> A few extra keys for 

I guess you were referring to property here, not key 

> 
> mysql55=enabled/disabled
> mysql57=enabled/disabled
> mysqlmaria=enabled/disabled

to avoid duplication of keys and properties I suggest to simply refer to the
existence of the contrib db key

if mysql57-mysqld exists in configuration db and its status is enabled we
backup it.
if mysql56-mysqld exists in configuration db and its status is enabled we
backup it.
if mysql55-mysqld exists in configuration db and its status is enabled we
backup it.
if mariadb exists in configuration db and its status is enabled we backup it.



if one disable it, it will stop backup. If one uninstalls without disabling you
will get error, and to remove the error just disable or delete the
configuration key for the db


You might add for each db a autobackup property defaulted to enabled unless it
has been define and set to disabled. In case one want to live on the edge and
not backup on mysql server.

> 
> Template the conf files allowing for enabled/disabled:
> 
> myserver.conf
> myserver55.conf
> myserver57.conf
> myservermaria.conf
> 
> Modify /sbin/e-smith/runmysqlbackup
> 
> #!/bin/sh
> 
> FILES=/etc/automysqlbackup/*.conf
> for f in $FILES
> do
> /usr/local/bin/automysqlbackup $f
> done
> 
> chown root:root /root/backup/db* -R
> find /root/backup/db* -type f -exec chmod 400 {} \;
> find /root/backup/db* -type d -exec chmod 700 {} \;
> 
> Then there is no need to modify the cron script as the runmysqlbackup script
> will process all conf files.
> 
> Things to think about.
> Do we check for installed versions if we can enable/disable conf files - a
> note in the wiki may suffice
> 
> The rpm automatically setups a 'backup' user in the DB with a password in
> the config. Do we add a note somewhere to say 'Don't forget to add a backup
> user'? If not we'd have to check for the existence of a particular version
> and then add the user. That doesn't help if a DB type is subsequently added.

 except that your conf file once generated will always be present, templates
are not meant to delete the file if it is empty,  what happens if  file is
empty. We might rather to update the cron sript too to call individually the
files if you get errors.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
_______________________________________________
Mail for each SME Contribs bug report
To unsubscribe, e-mail contribteam-unsubscr...@lists.contribs.org
Searchable archive at https://lists.contribs.org/mailman/public/contribteam/

Reply via email to