https://bugs.contribs.org/show_bug.cgi?id=9033

--- Comment #73 from John Crisp <[email protected]> ---
Seen an issue here which I didn't know about:

https://bugs.contribs.org/show_bug.cgi?id=10639#c12

Use of uninitialized value $city in string eq at
/usr/share/qpsmtpd/plugins/check_badcountries line 266.

This is probably when the City has not been found.

    # City Information in case we want to play later
    my $city = $self->qp->connection->notes('geoip_city');
    #warn ("At City (check): $city");
    if ($city eq '') {
        $self->log(LOGINFO, "Information: City NA RemoteIP $ip");
    }
    else {
        $self->log(LOGINFO, "Information: City $city RemoteIP $ip");
    }

I should probably change the line as follows:

    my $city = $self->qp->connection->notes('geoip_city') | '';

Anyone want to give it a quick test ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
_______________________________________________
Mail for each SME Contribs bug report
To unsubscribe, e-mail [email protected]
Searchable archive at https://lists.contribs.org/mailman/public/contribteam/

Reply via email to