On Mon, 8 May 2017 16:23:32 +0200 Michael Vorburger <vorbur...@redhat.com> wrote: > do you have any objection to merging > https://git.opendaylight.org/gerrit/#/c/54885/ ?
Yes ;-). See my comment on the patch. (Nothing major, just the tests.) > PS: A theoretical alternative to what I'm proposing would be to > somehow brute force ALL ODL Pax Exam tests to ALWAYS have a (new?) > feature of controller installed which includes the Blueprint extender > bundle. Personally I find that wrong, as to me that seems to break > modularity; one should not have to depend on controller e.g. in > infrautils, or any other bundle anywhere which wants to use BP but > not ODL specific extensions (and there are many like this), and we > practically could not really cleanly make odlparent's SFT Pax Exam > hard depend on installing a controller feature anyway. Agreed, I don’t think this is sensible. > PPS: I'll interpret no replies on this in 1 week from now as tacit > "OK sure go ahead" and self-merge c/54885 in 1 week. If you think > it's a good idea please do reply with at least a short "fine by me" > so we can merge this sooner! We don’t self-merge in odlparent, except for reverts or cherry-picks. (We can always discuss this of course, but so far it’s worked quite well. Yes, I realise this is an unwritten rule — AFAICT — and *that* could be improved.) Regards, Stephen
pgp5NsC8NCdXF.pgp
Description: OpenPGP digital signature
_______________________________________________ controller-dev mailing list controller-dev@lists.opendaylight.org https://lists.opendaylight.org/mailman/listinfo/controller-dev
