Buchan Milne wrote:

Florin, I noticed that in your spec file you removed the buildrequire for e2fsprogs, why? (look at the changelog: I removed it too once but readded it in 2.1.5-2mdk since it is necessary to find the headers for the system libcom_err, otherwise cyrus would compile its own replacement).


I think recent krb5-devel provides headers for libcom_err (actually conflicts with libext2fs2-devel IIRC). I guess ideally libcom_err should be split out?

Really strange, in 9.1 and before, the shared library comes from krb5-libs, while the headers come from libext2fs2-devel (ext2fs-devel). Was that a long standing error corrected in cooker? In that case it's probably better to put a conditional BuildRequires in order not to break compilation on older releases. The following modifications (untested) should do it:

--- cyrus-imapd.spec.orig       2003-07-20 17:01:11.000000000 +0200
+++ cyrus-imapd.spec    2003-07-20 17:02:39.000000000 +0200
@@ -2,6 +2,8 @@
 %define mdk82 %(awk '{print ($4 <= "8.2")}' /etc/mandrake-release)
 # detect if building under mandrake 9.0
 %define mdk90 %(awk '{print ($4 <= "9.0")}' /etc/mandrake-release)
+# detect if building under mandrake 9.1
+%define mdk91 %(awk '{print ($4 <= "9.1")}' /etc/mandrake-release)

 Name:          cyrus-imapd
 Version:       2.1.14
@@ -91,7 +93,9 @@
 Conflicts:     courier-imap
 BuildRequires: autoconf
 BuildRequires: libsasl2-devel
+if %{mdk82} || %{mdk90} || %{mdk91}
 BuildRequires: e2fsprogs-devel
+%endif
 BuildRequires: perl-devel
 BuildRequires: tcp_wrappers-devel
 %if %{mdk82} || %{mdk90}


Bye -- Que les importa a las viudas, a los hu�rfanos, a los desvalidos si las masacres se hacen en nombre del totalitarismo o en el sagrado nombre de la libertad y la democracia. Mahatma Gandhi (1869 - 1948)

Attachment: pgp00000.pgp
Description: PGP signature



Reply via email to