On Monday, September 19, 2016 1:53:08 PM CEST Miroslav Suchý wrote: > This is not really bug. So I will close it in BZ. But I'm happy to discuss it > here. > > I disagree that we need code review before push. This is quite small project, > with only few active developers.
Agreed. That said, I don't think we "need" it, but with the importance of Copr service(s), I can say it is sad we don't have a capacity for code review, that's always useful in every project. > If you want to do review, then you can subscribe to: > https://lists.fedorahosted.org/admin/lists/copr-commits.lists.fedorahosted.org/ > And comment the commit here on this mailing list. If needed, it can be > rejected. Thanks, I'll subscribe there. Let's hope I'll be able to find good heuristic to pick important changes for review -- but unfortunately, I can not review everything. Is there possibility to highlight important changes? Pavel > -------- Přeposlaná zpráva -------- > Předmět: [Bug 1376844] New: Please start using processes like code-review, > etc. > Datum: Fri, 16 Sep 2016 14:53:30 +0000 > Od: [email protected] > Komu: [email protected] > > https://bugzilla.redhat.com/show_bug.cgi?id=1376844 > > Bug ID: 1376844 > Summary: Please start using processes like code-review, etc. > Product: Copr > Component: backend > Assignee: [email protected] > Reporter: [email protected] > > > > Copr is starting to be very popular and key part of Fedora's and Red Hat's > infrastructure, and it deserves proper processes. I'm not talking about hard > bureaucracy, but some clear 'Pull-request -> code-review -> push' is enough. > If there is done something like that in background (I strongly believe there > is) please open that process. > > I'd be glad to be part of the review process if there is something really > design breaking. > > Copr really needs new consumer, that is important point, so please: > > - let's not hard-wire anything specific to Fedora instance copr > - if there is something Fedora-instance specific, make it optional, pluggable > thing > > _______________________________________________ copr-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
