[ 
https://issues.apache.org/jira/browse/HADOOP-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564073#action_12564073
 ] 

Tom White commented on HADOOP-938:
----------------------------------

bq. Another approach would be to add an open() method, and use 
SequenceFile.Writer setter methods

I like this best, since it is simple. I think adding an open() method is good 
since it also makes Writer (and Reader) easier to subclass (HADOOP-2739). 
Currently they do IO in the constructor which can make it impossible for a 
subclass to do its initialization first - see 
https://issues.apache.org/jira/browse/HADOOP-1398?focusedCommentId=12559089#action_12559089.

> too many SequenceFile.createWriter() methods
> --------------------------------------------
>
>                 Key: HADOOP-938
>                 URL: https://issues.apache.org/jira/browse/HADOOP-938
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: io
>            Reporter: Doug Cutting
>
> There are too many SequenceFile.createWriter() method signatures.  This 
> method has two required paramters: a Configuration and a Path.  It has one 
> obsolete parameter: a FileSystem.  And it has five optional parameters: 
> CompressionType, CompressionCodec, Progress, replication, and metadata.
> We should remove the obsolete parameter and make all optional parameters into 
> setters.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to