[
https://issues.apache.org/jira/browse/HADOOP-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568276#action_12568276
]
Owen O'Malley commented on HADOOP-2027:
---------------------------------------
You should:
1. Not use strings of '*' around your javadoc.
2. Fill in the javadoc of public methods in BlockLocation.
3. I'd prefer using String[] in BlockLocation, since the API uses String
rather than Text.
4. FileSystem.getFileBlockLocations should just pass the desired values into
the constructor rather than setting them all, same for DFSClient
5. The indentation in FileInputFormat should bring lines to the open of the
paren
6. Fix the calls to the now deprecated methods.
Thanks! I'm looking forward to this patch.
> FileSystem should provide byte ranges for file locations
> --------------------------------------------------------
>
> Key: HADOOP-2027
> URL: https://issues.apache.org/jira/browse/HADOOP-2027
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Reporter: Owen O'Malley
> Assignee: lohit vijayarenu
> Attachments: HADOOP-2027-1.patch
>
>
> FileSystem's getFileCacheHints should be replaced with something more useful.
> I'd suggest replacing getFileCacheHints with a new method:
> {code}
> BlockLocation[] getFileLocations(Path file, long offset, long range) throws
> IOException;
> {code}
> and adding
> {code}
> class BlockLocation implements Writable {
> String[] getHosts();
> long getOffset();
> long getLength();
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
