[ 
https://issues.apache.org/jira/browse/HADOOP-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568498#action_12568498
 ] 

Hadoop QA commented on HADOOP-2027:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12375464/HADOOP-2027-2.patch
against trunk revision 619744.

    @author +1.  The patch does not contain any @author tags.

    tests included +1.  The patch appears to include 30 new or modified tests.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac -1.  The applied patch generated 608 javac compiler warnings (more 
than the trunk's current 604 warnings).

    release audit +1.  The applied patch does not generate any new release 
audit warnings.

    findbugs -1.  The patch appears to introduce 3 new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1788/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1788/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1788/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1788/console

This message is automatically generated.

> FileSystem should provide byte ranges for file locations
> --------------------------------------------------------
>
>                 Key: HADOOP-2027
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2027
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: fs
>            Reporter: Owen O'Malley
>            Assignee: lohit vijayarenu
>         Attachments: HADOOP-2027-1.patch, HADOOP-2027-2.patch, 
> HADOOP-2027-3.patch
>
>
> FileSystem's getFileCacheHints should be replaced with something more useful. 
> I'd suggest replacing getFileCacheHints with a new method:
> {code}
> BlockLocation[] getFileLocations(Path file, long offset, long range) throws 
> IOException;
> {code}
> and adding
> {code}
> class BlockLocation implements Writable {
>   String[] getHosts();
>   long getOffset();
>   long getLength();
> }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to