[ 
https://issues.apache.org/jira/browse/HADOOP-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568906#action_12568906
 ] 

Hemanth Yamijala commented on HADOOP-2775:
------------------------------------------

Some comments:

- Let's move the tests under hod directly instead of under hod/hodlib.
- The 'main' module is not being properly excluded as expected. By the same 
argument, any file which does not begin with test will not be excluded. I think 
we should worry about excluding only *test* modules, where test modules, by our 
convention, start with 'test'
- The code in the test module's runTests is repeated. We should explore pulling 
it out into a common place, like a base class.
- I am not sure we should have tests beginning with _test_. Can't we just have 
them begin with test_ ?
- The output from the tests, when run through 'ant test', is in the wrong 
order.  We can either remove our outputs, or put them in the right order.

> [HOD] Put in place unit test framework for HOD
> ----------------------------------------------
>
>                 Key: HADOOP-2775
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2775
>             Project: Hadoop Core
>          Issue Type: Test
>          Components: contrib/hod
>    Affects Versions: 0.16.0
>            Reporter: Hemanth Yamijala
>            Assignee: Vinod Kumar Vavilapalli
>             Fix For: 0.17.0
>
>         Attachments: patch_unittesting, patch_unittesting.1
>
>
> HOD does not have any unit tests in place currently. This issue is to decide 
> on a framework that would be effective for our python code base. Something on 
> the lines of pyUnit would be good. The fix should put in place any 
> dependencies needed for running the tests, and should also define some tests 
> that demonstrate how to write further tests. We would not be defining a 
> complete unit test suite for the entire code base right now, but would 
> incrementatlly add tests as changes are made.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to