[ 
https://issues.apache.org/jira/browse/HADOOP-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569839#action_12569839
 ] 

Hemanth Yamijala commented on HADOOP-2775:
------------------------------------------

Looks good now.. Few more comments:

- Failing test cases should fail the ant test task
- Currently, contrib test target would fail if a required python version is not 
specified or available. This would be inconvenient for users not interested in 
running HOD unit tests, but would like to fire a test build at the contrib 
level. We could simply ignore running the tests if the required python is not 
found. However, that has a side-effect of hiding misconfigured python  on 
Hudson. Given that the latter would be rare, and is a one time setup, I would 
still go with that approach. Comments ?
- At a suite level only tearDown is defined, but not setUp.
- Can we make the directory 'test' rather than 'Testing' - just a more 
conventional name.

> [HOD] Put in place unit test framework for HOD
> ----------------------------------------------
>
>                 Key: HADOOP-2775
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2775
>             Project: Hadoop Core
>          Issue Type: Test
>          Components: contrib/hod
>    Affects Versions: 0.16.0
>            Reporter: Hemanth Yamijala
>            Assignee: Vinod Kumar Vavilapalli
>             Fix For: 0.17.0
>
>         Attachments: patch_unittesting, patch_unittesting.1, 
> patch_unittesting.2, patch_unittesting.3
>
>
> HOD does not have any unit tests in place currently. This issue is to decide 
> on a framework that would be effective for our python code base. Something on 
> the lines of pyUnit would be good. The fix should put in place any 
> dependencies needed for running the tests, and should also define some tests 
> that demonstrate how to write further tests. We would not be defining a 
> complete unit test suite for the entire code base right now, but would 
> incrementatlly add tests as changes are made.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to