[
https://issues.apache.org/jira/browse/HADOOP-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582591#action_12582591
]
Tom White commented on HADOOP-1915:
-----------------------------------
With random writer with 0 length values it takes 46s with trunk and 46s with
the patch (averaged over 3 runs). With a profiler I see that for trunk, it is
spending 2% (716ms average) of the time in the Counters code (in
Counters.findCounter). For the patch, it is spending 1% (485ms average) of the
time in the Counters code (in Counters.findCounter).
Based on this, the patch looks OK.
> adding counters methods using String (as opposed to Enum)
> ---------------------------------------------------------
>
> Key: HADOOP-1915
> URL: https://issues.apache.org/jira/browse/HADOOP-1915
> Project: Hadoop Core
> Issue Type: New Feature
> Environment: all
> Reporter: Alejandro Abdelnur
> Assignee: Tom White
> Priority: Minor
> Fix For: 0.17.0
>
> Attachments: hadoop-1915-v2.patch, hadoop-1915.patch
>
>
> Currently to use the counters from within Map/Reduce code Enums have to be
> used, the Enum class defines the group and the Enum itself the counter.
> Internally they are converted to Strings (the class name and the enum
> toString) and you can retrieve them as strings from the client API.
> Using dynamic counters (driven by configuration of the map/reduce) is not
> easy with the counters Enum based API. For example, currently I have an Enum
> class with 50 enums and we have to map the cardinality to the counter name on
> the client. This is cumbersome.
> This could be easily improve by adding a String based counter method
> increment(String group, String counter, long count) to allow use of the
> counters without Enums.
> Internally this method already exists, so the changes are minimal.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
