[
https://issues.apache.org/jira/browse/HADOOP-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591833#action_12591833
]
Owen O'Malley commented on HADOOP-544:
--------------------------------------
I'd propose that we change the names of the id classes toward a less confusing
system:
JobId
TaskId
TaskAttemptId
I think it is better not to import each of the values of enumerations, so that
you always have the type name associated with the value.
Thanks for all of the hard work on this Enis!
> Replace the job, tip and task ids with objects.
> -----------------------------------------------
>
> Key: HADOOP-544
> URL: https://issues.apache.org/jira/browse/HADOOP-544
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.18.0
> Reporter: Owen O'Malley
> Assignee: Enis Soztutar
> Fix For: 0.18.0
>
> Attachments: id_v1.patch, id_v2.patch, id_v3.patch, id_v4.patch,
> id_v5.patch, id_wip1.patch
>
>
> I think that it is silly to have tools parsing the strings that the framework
> builds for task ids. I propose:
> class JobId implements Writable {
> public int getJobId() {...}
> }
> class TaskId implements Writable {
> public JobId getJobId();
> public boolean isMap() { ... }
> public int getTaskId() { ... }
> }
> class TaskAttemptId implements Writable {
> public TaskId getTaskId();
> public int getAttemptId();
> }
> each of the classes will have a toString() method that generates the current
> string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
