[
https://issues.apache.org/jira/browse/HADOOP-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593206#action_12593206
]
Hadoop QA commented on HADOOP-544:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12381151/id_v7.patch
against trunk revision 645773.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 12 new or modified tests.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler
warnings.
release audit +1. The applied patch does not generate any new release
audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests -1. The patch failed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2346/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2346/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2346/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2346/console
This message is automatically generated.
> Replace the job, tip and task ids with objects.
> -----------------------------------------------
>
> Key: HADOOP-544
> URL: https://issues.apache.org/jira/browse/HADOOP-544
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.18.0
> Reporter: Owen O'Malley
> Assignee: Enis Soztutar
> Fix For: 0.18.0
>
> Attachments: id_v1.patch, id_v2.patch, id_v3.patch, id_v4.patch,
> id_v5.patch, id_v6.patch, id_v7.patch, id_wip1.patch
>
>
> I think that it is silly to have tools parsing the strings that the framework
> builds for task ids. I propose:
> class JobId implements Writable {
> public int getJobId() {...}
> }
> class TaskId implements Writable {
> public JobId getJobId();
> public boolean isMap() { ... }
> public int getTaskId() { ... }
> }
> class TaskAttemptId implements Writable {
> public TaskId getTaskId();
> public int getAttemptId();
> }
> each of the classes will have a toString() method that generates the current
> string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
