[ 
https://issues.apache.org/jira/browse/HADOOP-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613911#action_12613911
 ] 

Amareshwari Sriramadasu commented on HADOOP-3150:
-------------------------------------------------

bq. It is making error prone for people implementing their own OutputFormat to 
get things wrong.
Errors in commit logic will affect the task only. The framework will be safe, 
right?

bq. I would prefer to leave the OutputFormat interface as it is today and have 
a separate interface OutputCommitter and have an implementation of it for file 
based output formats and have an OutputCommitterFactory that gives you the 
right OutputCommitter for the job OutputFormat. Similar to how Serializations 
are picked.
Making OutputFormat an abstract is always advantageous. Adding OutputCommiter 
sounds good. That could be addressed in a seperate jira, which moves the commit 
logic to OutputCommitter.


> Move task file promotion into the task
> --------------------------------------
>
>                 Key: HADOOP-3150
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3150
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>            Reporter: Owen O'Malley
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.19.0
>
>         Attachments: 3150.patch, patch-3150.txt
>
>
> We need to move the task file promotion from the JobTracker to the Task and 
> move it down into the output format.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to