[
https://issues.apache.org/jira/browse/HADOOP-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618635#action_12618635
]
Tom White commented on HADOOP-3866:
-----------------------------------
Craig, this looks like a good addition. A few comments:
1. By default you should not be able kill jobs from the web UI (see
https://issues.apache.org/jira/browse/HADOOP-1484). So you should only show the
button to kill jobs if webinterface.private.actions is set to true. (Changing
priorities is always allowed.) Equally importantly you should only respond to a
POST request to kill jobs if the property is set to true.
2. Change "Delete Selected" to "Kill Selected Jobs" for consistency with with
the command line interface and the rest of UI.
3. Rename hadoop.js to jobtracker.js to encourage modularity of javascript
files.
4. Would it be better to put the filter box with the content that it filters?
I.e. in a section that includes running, completed and failed jobs.
5. Can we left-justify the tables and the header for consistency with the HDFS
interface?
6. Should we use a library like prototype (http://www.prototypejs.org/) to make
the javascript work better across browsers?
Finally, I notice that the JSPs have a lot of embedded Java (this is true with
the current code: this patch is just following the current style), which makes
them hard to test and hard to extend or reuse. Is there a better design we
should adopt so that we can aim to improve our code over time? Thoughts?
> Improve Hadoop Jobtracker Admin
> -------------------------------
>
> Key: HADOOP-3866
> URL: https://issues.apache.org/jira/browse/HADOOP-3866
> Project: Hadoop Core
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 0.16.4
> Environment: javascript functionality will target firefox
> Reporter: craig weisenfluh
> Assignee: craig weisenfluh
> Fix For: 0.19.0
>
> Attachments: admin-1.patch
>
>
> A number of enhancements to the jobtracker jsp that allow for searching,
> scheduling, and navigating a large number of jobs. These enhancements are
> to be added as subtasks, to follow.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
