[
https://issues.apache.org/jira/browse/HADOOP-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618645#action_12618645
]
Steve Loughran commented on HADOOP-3866:
----------------------------------------
>Finally, I notice that the JSPs have a lot of embedded Java (this is true with
>the current code: this patch is just following the current style), which makes
>them hard to test and hard to extend or reuse. Is there a better design we
>should adopt so that we can aim to improve our code over time? Thoughts?
I've noticed that too. It's not ideal, and the use of JSP forces hadoop to have
the jasper runtimes.
Some options
1. Move to JSP tags and define custom tags for lots of the reporting.
+Moves some of the work into Java classes
+lets you do some layout/graphics logic in the JSP pages
-makes for an even more complex build/test process
-lots of engineering work which is hard to justify unless the tags are reused
-may move some html output into the Java source
2. Move all the html generation to the java source.
+ could use something like xmlenc to make it cleaner
+ eliminates jspc and the jasper jars
- xmlenc isn't namespace aware; cannot do XHTML, would need an updated rewrite
- doing all the presentation in jsp code is pretty ugly too
- would need a new servlet for every page
> Improve Hadoop Jobtracker Admin
> -------------------------------
>
> Key: HADOOP-3866
> URL: https://issues.apache.org/jira/browse/HADOOP-3866
> Project: Hadoop Core
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 0.16.4
> Environment: javascript functionality will target firefox
> Reporter: craig weisenfluh
> Assignee: craig weisenfluh
> Fix For: 0.19.0
>
> Attachments: admin-1.patch
>
>
> A number of enhancements to the jobtracker jsp that allow for searching,
> scheduling, and navigating a large number of jobs. These enhancements are
> to be added as subtasks, to follow.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
