[ 
https://issues.apache.org/jira/browse/HADOOP-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Douglas updated HADOOP-3894:
----------------------------------

    Status: Open  (was: Patch Available)

* This change should be reverted:
{noformat}
@@ -157,6 +162,7 @@
     // run the job. It will fail with IOException.
     try {
       job = new JobClient(conf).submitJob(conf);
+      //fail("Expected job submission to fail here");
     } catch (IOException e) {
      LOG.info("Running Job failed", e);
     }
{noformat}
* Should TestMiniMRMapRedDebugScript manage its own timeouts? This seems like 
ant's responsibility, though removing the busy loop is clearly an improvement. 
The test takes less than a minute to run, but I'm not sure that taking longer 
than that necessarily implies failure, neither is it going to take considerably 
less time without the loop.
* Why is it preferred to check that the output contains what was expected, 
rather than being exactly what was expected?
* This adds a parameter to processDatanodeError, but doesn't reference it.

I'm not sure I understand what this JIRA addresses...

> DFSClient chould log errors better, and provide better diagnostics
> ------------------------------------------------------------------
>
>                 Key: HADOOP-3894
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3894
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Trivial
>             Fix For: 0.19.0
>
>         Attachments: hadoop-3894.patch, hadoop-3894.patch
>
>
> In my test runs I see a stack trace from DFSClient, because it isn't logging 
> through the log APIs in its close() method. It should use the logger, for 
> better error reporting

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to