[
https://issues.apache.org/jira/browse/HADOOP-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626708#action_12626708
]
Steve Loughran commented on HADOOP-3894:
----------------------------------------
Chris, I'll look at this next week; I'm don't have access to my development
machine right now.
-Timeouts in tests are interesting. When Ant times out a test run it kills the
JVM; you lose the trace of where things got to. Its much better to have the
test routine doing its own timeouts and saying where they failed. But the
timeouts should be
1. shared across all tests for easy maintenance
2. configurable by whoever runs the test
which really means shared default timeouts that can be overridden from system
properties, and hence in the IDE (useful for stepping through code) or
build.properties
I could make this a separate improvement issue if you like.
-The reason I switched to using contains() in the text output rather than just
equals() was that once log4j starts getting involved in DFSClient output, the
output started to look different. I can't recall what, but I can capture it.
> DFSClient chould log errors better, and provide better diagnostics
> ------------------------------------------------------------------
>
> Key: HADOOP-3894
> URL: https://issues.apache.org/jira/browse/HADOOP-3894
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Trivial
> Fix For: 0.19.0
>
> Attachments: hadoop-3894.patch, hadoop-3894.patch
>
>
> In my test runs I see a stack trace from DFSClient, because it isn't logging
> through the log APIs in its close() method. It should use the logger, for
> better error reporting
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
