[
https://issues.apache.org/jira/browse/HADOOP-3315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629567#action_12629567
]
Doug Cutting commented on HADOOP-3315:
--------------------------------------
Util.java serves no purpose. It mostly contains a number of package-private
classes that should be independent files. Also much of its code seems
redundant:
- Is Util#memcmp different from WritableComparator#compareBytes()?
- Shouldn't BoundedByteArrayOutputStream extend ByteArrayOutputStream?
- the VLong code duplicates code in WritableUtils, no?
- readString/writeString duplicates Text methods.
- should the Compression enum be simply a new method on
CompressionCodecFactory? If not, shouldn't it go in the io.compress package?
If these differ in subtle ways from the versions elsewhere in Hadoop then the
justification for near-duplication of implementation should be made in a
comment.
I got tired of reading the patch after that. For a simpler implementation, it
seems very complicated. The implementation of TFile is around 3.9k lines of
Java. SequenceFile, which is thought to be too complicated, is only 3.1k lines.
> New binary file format
> ----------------------
>
> Key: HADOOP-3315
> URL: https://issues.apache.org/jira/browse/HADOOP-3315
> Project: Hadoop Core
> Issue Type: New Feature
> Components: io
> Reporter: Owen O'Malley
> Assignee: Amir Youssefi
> Attachments: HADOOP-3315_TFILE_PREVIEW.patch
>
>
> SequenceFile's block compression format is too complex and requires 4 codecs
> to compress or decompress. It would be good to have a file format that only
> needs
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
