[ https://issues.apache.org/jira/browse/HADOOP-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634789#action_12634789 ]
Hemanth Yamijala commented on HADOOP-4178: ------------------------------------------ Looks mostly right. Couple of points: - I think it will be best to fail if the configured values are invalid. Hiding it may show up as problems later. - The computation for percentages are a float value, so I don't see the need to round still. There is some rounding done anyway when the actual capacity is computed. Let's handle any rounding related issues at one place there. I think the computation of the allocated capacity should be simple, and just divided equally at the configuration level. > The capacity scheduler's defaults for queues should be configurable. > -------------------------------------------------------------------- > > Key: HADOOP-4178 > URL: https://issues.apache.org/jira/browse/HADOOP-4178 > Project: Hadoop Core > Issue Type: Improvement > Components: contrib/capacity-sched > Affects Versions: 0.19.0 > Reporter: Owen O'Malley > Assignee: Sreekanth Ramakrishnan > Priority: Blocker > Fix For: 0.19.0 > > Attachments: HADOOP-4178-1.patch, HADOOP-4178-2.patch, > HADOOP-4178-3.patch, HADOOP-4178-4.patch, HADOOP-4178-5.patch > > > The default values for the queue attributes should be configurable rather > than hard coded. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.