[
https://issues.apache.org/jira/browse/HADOOP-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635296#action_12635296
]
Hemanth Yamijala commented on HADOOP-4178:
------------------------------------------
Some minor changes:
- capacity-scheduler-conf.xml.template - The new configuration items are not
expanding tabs to spaces. We follow the same convention for tabs even for conf
files.
- {{getMinimumUserLimitPercent}} is looking up the property name twice.
- Due to recent changes, the LOG variable is again unused.
- Tests for invalid values are not correct. They don't add the invalid values
to the configuration file.
The tests are passing because upon construction, no checks are done. You must
do a get in order to exercise the error checking code. Also, if the Exception
is expected, it is good to have a {{fail}} line in the success path. Otherwise,
erroneously, the wrong test will produce successful results. So, the code
should be something like this:
{code}
try {
testConf = new CapacitySchedulerConf(new Path(testConfFile));
testConf.getInvalidReclaimTimeLimit("default");
fail("Expect invalid reclaim time limit to raise exception");
} catch(IllegalArgumentException e) {
assertTrue(true);
}
{code}
> The capacity scheduler's defaults for queues should be configurable.
> --------------------------------------------------------------------
>
> Key: HADOOP-4178
> URL: https://issues.apache.org/jira/browse/HADOOP-4178
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/capacity-sched
> Affects Versions: 0.19.0
> Reporter: Owen O'Malley
> Assignee: Sreekanth Ramakrishnan
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4178-1.patch, HADOOP-4178-2.patch,
> HADOOP-4178-3.patch, HADOOP-4178-4.patch, HADOOP-4178-5.patch,
> HADOOP-4178-6.patch
>
>
> The default values for the queue attributes should be configurable rather
> than hard coded.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
