[ https://issues.apache.org/jira/browse/HADOOP-4293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635177#action_12635177 ]
Hadoop QA commented on HADOOP-4293: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12391085/4293-2.patch against trunk revision 699676. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3388/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3388/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3388/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3388/console This message is automatically generated. > Remove WritableJobConf > ----------------------- > > Key: HADOOP-4293 > URL: https://issues.apache.org/jira/browse/HADOOP-4293 > Project: Hadoop Core > Issue Type: Bug > Components: mapred > Affects Versions: 0.19.0 > Reporter: Owen O'Malley > Assignee: Owen O'Malley > Fix For: 0.19.0 > > Attachments: 4293-2.patch, 4293.patch > > > The new class WritableJobConf doesn't add value over just making JobConf > Writable, and I propose that we remove it before it is released. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.