[
https://issues.apache.org/jira/browse/HADOOP-4293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635290#action_12635290
]
Owen O'Malley commented on HADOOP-4293:
---------------------------------------
Hmm... I don't see what is wrong with option 1. It does introduce an
incompatibility, but in a place where it is unlikely to break clients. The
change was *not* extensive. The entire patch is 12k and there were 9 calls to
the old write. And it provides the functionality in a way that fits the
expected behavior.
In HADOOP-1230, we're going deprecate JobConf. So I don't think having a
subclass that adds readers/writers doesn't seem right. I'm also not very happy
with the write(OutputStream) versus write(DataOutput), which can easily lead to
confusion.
And using the binary format instead of the xml for job submission would make a
lot of sense, be much much faster, and avoid all of the quoting problems of
using xml to serialize the configuration.
> Remove WritableJobConf
> -----------------------
>
> Key: HADOOP-4293
> URL: https://issues.apache.org/jira/browse/HADOOP-4293
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.19.0
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.19.0
>
> Attachments: 4293-2.patch, 4293.patch
>
>
> The new class WritableJobConf doesn't add value over just making JobConf
> Writable, and I propose that we remove it before it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
