[ https://issues.apache.org/jira/browse/HADOOP-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647369#action_12647369 ]
Hadoop QA commented on HADOOP-4649: ----------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12393834/4649-0.patch against trunk revision 713723. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3585/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3585/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3585/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3585/console This message is automatically generated. > Improve abstraction for spill indices > ------------------------------------- > > Key: HADOOP-4649 > URL: https://issues.apache.org/jira/browse/HADOOP-4649 > Project: Hadoop Core > Issue Type: Improvement > Reporter: Chris Douglas > Assignee: Chris Douglas > Priority: Minor > Fix For: 0.20.0 > > Attachments: 4649-0.patch > > > In support of changing checksum handling as part of the migration to Jetty6, > some of the spill code would be easier to reason about with a different > abstraction. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.