[
https://issues.apache.org/jira/browse/HADOOP-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651979#action_12651979
]
Jothi Padmanabhan commented on HADOOP-4649:
-------------------------------------------
Looks pretty good.
* Is there a reason why you do not use IFileInputStream/IFileOuptutStream in
SpillRecord? The CRC addition/vadlidation code is very similar to that in
IFIleInput/Output Streams. If at a later stage, we decide to use a different
checksum other than CRC32 in IFile, we should modify here as well, if we just
want to be consistent. Agreed that it will not break anything if this continues
to use CRC32, but it might just be better to use the same as in
IFileInput/Output stream, unless there is a compelling reason otherwise.
* We do not expect this change to have any performance impact, but could you
verify *just in case*, if you have not already.
* A few other minor points
# SpillRecord.java: import org.apache.hadoop.fs.LocalFileSystem is not used
# IndexCache.java import java.io.FileNotFoundException is not used
# MapTask.java:1230, rawSegmentLength is not used anywhere
> Improve abstraction for spill indices
> -------------------------------------
>
> Key: HADOOP-4649
> URL: https://issues.apache.org/jira/browse/HADOOP-4649
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: 4649-0.patch, 4649-1.patch
>
>
> In support of changing checksum handling as part of the migration to Jetty6,
> some of the spill code would be easier to reason about with a different
> abstraction.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
