[
https://issues.apache.org/jira/browse/HADOOP-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653573#action_12653573
]
Tsz Wo (Nicholas), SZE commented on HADOOP-4348:
------------------------------------------------
Some comments on the patch:
- Do we need to check for superuser in order to run
refreshAuthorizationPolicy() in MRAdmin and DFSAdmin?
- Perission subclasses must be immutable. So their fields should be final.
- Similarly, User and Group principals are better be immutable.
- Why any ConnectionPermission implies ConnectionPermission of
VersionedProtocol? Also, the implies(..) method need javadoc.
- ConnectionPermission .getActions() should not return null. How about
returning ALLOWED? Then, we could support negative permission setting by
adding DENIED in the future.
- Need descriptions for the properties in hadoop-policy.xml, especially for the
syntax. These documentation changes may be done in a separated issue.
- I think using multiplication in hashCode() may not be a good idea. How about
address.hashCode() ^ protocol.hashCode() ^ System.identityHashCode(ticket)?
- Should we throw IOException instead of RuntimeException when there is a
LoginException? Also, it is better the include the cause exception in the new
exception.
- In AuthorizationException, how about calling setStackTrace(null) to clean up
the trace?
- The changes in IsolationRunner and LocalJobRunner should be reverted.
> Adding service-level authorization to Hadoop
> --------------------------------------------
>
> Key: HADOOP-4348
> URL: https://issues.apache.org/jira/browse/HADOOP-4348
> Project: Hadoop Core
> Issue Type: New Feature
> Components: security
> Reporter: Kan Zhang
> Assignee: Arun C Murthy
> Fix For: 0.20.0
>
> Attachments: HADOOP-4348_0_20081022.patch,
> HADOOP-4348_1_20081201.patch, HADOOP-4348_2_20081202.patch,
> HADOOP-4348_3_20081204.patch, jaas_service_v1.patch, jaas_service_v2.patch,
> jaas_service_v3.patch, ServiceLevelAuthorization.pdf,
> ServiceLevelAuthorization.pdf
>
>
> Service-level authorization is the initial checking done by a Hadoop service
> to find out if a connecting client is a pre-defined user of that service. If
> not, the connection or service request will be declined. This feature allows
> services to limit access to a clearly defined group of users. For example,
> service-level authorization allows "world-readable" files on a HDFS cluster
> to be readable only by the pre-defined users of that cluster, not by anyone
> who can connect to the cluster. It also allows a M/R cluster to define its
> group of users so that only those users can submit jobs to it.
> Here is an initial list of requirements I came up with.
> 1. Users of a cluster is defined by a flat list of usernames and groups.
> A client is a user of the cluster if and only if her username is listed in
> the flat list or one of her groups is explicitly listed in the flat list.
> Nested groups are not supported.
> 2. The flat list is stored in a conf file and pushed to every cluster
> node so that services can access them.
> 3. Services will monitor the modification of the conf file periodically
> (5 mins interval by default) and reload the list if needed.
> 4. Checking against the flat list is done as early as possible and before
> any other authorization checking. Both HDFS and M/R clusters will implement
> this feature.
> 5. This feature can be switched off and is off by default.
> I'm aware of interests in pulling user data from LDAP. For this JIRA, I
> suggest we implement it using a conf file. Additional data sources may be
> supported via new JIRA's.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
